Colors #25
Open
Colors #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wolfy1339
added
enhancement
ghost
assigned
wolfy1339
force-pushed
the
colors
branch
3 times, most recently
from
bbba240 to
fe246be
Compare
BWBellairs
reviewed
Apr 27, 2018
| * @param {string} [style=null] | ||
| */ | ||
| privmsg(target, message) { | ||
| privmsg(target, message, background=null, rainbow=false, style=null) { |
Member
There was a problem hiding this comment.
I think it'd be better for plugins/root to add colours to the message before calling message functions with it hence the extra three arguments wouldn't be necessary.
Member
There was a problem hiding this comment.
Yeah, it would be nice if colours were provided as a util. Maybe something like
const colors = require('../utils/colors.js');
colors("some text").red().bold();
Member
Author
There was a problem hiding this comment.
I wouldn't know how to do that kind of function, with the chained functions
Add JSDoc comments (placeholders mostly for now) Rename string variables to msg to better reflect their usage
Switched parameters around and ended up re-adding the reply infinite loop and replying in PRIVMSG instead of in the channel (if the message was sent in a channel)�
- Strip the first byte (0x3) to get the color code - Color names are in upper case, so transform the argument for that
When using an empty string, String.prototype.concat doesn't seem to work, but using += does
wolfy1339
added
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.