Skip to content

Conversation

@elliotmendiola
Copy link

Before:
WoWScrnShot_101319_190237

After:
WoWScrnShot_101319_190249

Fixed how bags glows are updated when used with onebag, it was inverted
@elliotmendiola
Copy link
Author

This probably doesn't follow best practices and also is inefficient as it does a regex check every time the bag slots update on each of the bag slots, but it gets the job done and I'm not familiar with the code base nor best practices

@haste
Copy link
Owner

haste commented Oct 14, 2019

Thanks for the PR. Seems I didn't think of other add-ons re-using the Blizzard functions.

There are some changes I would suggest:

  • Move the frame name check outside the if
  • Change the check to if(name:sub(1, 14) == 'ContainerFrame') then. This way it validates that it's the correct frame, instead of checking if it's the wrong one

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants