-
Notifications
You must be signed in to change notification settings - Fork 10.1k
Add component registry source resolution support to Terraform Stacks #37888
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
d93fbe2 to
2c4787c
Compare
|
We'd like to target 1.14. Should we apply the backport label or change the target branch? |
Backported dependency changeThis PR makes changes to dependencies in go.mod file(s) and is labelled for backport. Notice to the maintainer: Before merging the backport of this PR please follow our security scanning processes. |
10b50f0 to
85a9cb4
Compare
jar-b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🎉
% TF_ACC=1 go test -count=1 ./...
go: downloading github.com/hashicorp/go-slug v0.18.1
ok github.com/hashicorp/terraform/internal/backend/remote-state/s3 209.243sThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on gcs side!
mau …/backend/remote-state/gcs jpogran/add_registry_component_source_support v1.25.0 14:17 TF_ACC=1 go test -count=1 ./...
go: downloading cloud.google.com/go/kms v1.15.5
ok github.com/hashicorp/terraform/internal/backend/remote-state/gcs 79.204sThis change implements the missing component source resolution case in the stack configuration loader, enabling Terraform Stacks to properly handle component registry sources from HCP Terraform and other component registries. The implementation mirrors the existing module registry resolution workflow, where component sources are first resolved to their versioned form using the source bundle's component metadata, then converted to final source addresses that can be used to locate the actual component code. This completes the integration between the terraform-registry-address component parsing capabilities and the go-slug sourcebundle component resolution APIs.
85a9cb4 to
ddc1d11
Compare
This change implements the missing component source resolution case in the stack configuration loader, enabling Terraform Stacks to properly handle component registry sources from HCP Terraform and other component registries.
The implementation mirrors the existing module registry resolution workflow, where component sources are first resolved to their versioned form using the source bundle's component metadata, then converted to final source addresses that can be used to locate the actual component code. This completes the integration between the terraform-registry-address component parsing capabilities and the go-slug sourcebundle component resolution APIs.
Fixes #
Target Release
1.15.x
Rollback Plan
Changes to Security Controls
Are there any changes to security controls (access controls, encryption, logging) in this pull request? If so, explain.
CHANGELOG entry