doc: Add a preliminary Haskell style guide. #991
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
I believe this addresses everything that we wrote in #143, and more. Comments & suggested additions welcome. |
brprice
reviewed
May 16, 2023
brprice
reviewed
May 16, 2023
brprice
reviewed
May 16, 2023
Closes #143 Signed-off-by: Drew Hess <src@drewhess.com>
Member
Author
|
I'm going to merge this now. It's easy enough to fix up later if anyone would like to make additional changes. |
georgefst
reviewed
May 17, 2023
|
|
||
| ## Cabal | ||
|
|
||
| * Start all new Cabal projects with `default-language: Haskell2010`. |
Contributor
There was a problem hiding this comment.
This seems odd in light of the fact that all of our default-language fields are currently set to GHC2021.
Member
Author
There was a problem hiding this comment.
Yeah, that's an oversight. I'll fix it, thanks.
Member
Author
|
Fixes can go here: #997 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #143