Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/cmds/core/user.py
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,7 @@ async def user_stats(self, ctx: ApplicationContext) -> Interaction | WebhookMess
else:
bots_count += 1

percent_verified = round(verified_members / members * 100)
percent_verified = round(verified_members / members * 100, 2)

# Create embed
embed = discord.Embed(title="HackTheBox Discord User Stats")
Expand Down
34 changes: 34 additions & 0 deletions tests/src/cmds/core/test_user.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,40 @@ async def test_kick_fail_user_left(self, ctx, guild, bot, session):
ctx.respond.assert_called_once_with("User seems to have already left the server.")


@pytest.mark.asyncio
async def test_user_stats(self, ctx, bot):
"""Test the user_stats command displays correct statistics."""
# Create mock members: 3 regular users (2 verified with roles, 1 unverified), 1 bot
verified_member1 = helpers.MockMember(id=1, name="Verified1", bot=False)
verified_member1.roles = [helpers.MockRole(id=0, name="@everyone"), helpers.MockRole(id=1, name="Verified")]

verified_member2 = helpers.MockMember(id=2, name="Verified2", bot=False)
verified_member2.roles = [helpers.MockRole(id=0, name="@everyone"), helpers.MockRole(id=2, name="Member")]

unverified_member = helpers.MockMember(id=3, name="Unverified", bot=False)
unverified_member.roles = [helpers.MockRole(id=0, name="@everyone")]

bot_member = helpers.MockMember(id=4, name="BotUser", bot=True)

ctx.guild.members = [verified_member1, verified_member2, unverified_member, bot_member]
ctx.user = helpers.MockMember(id=100, name="Admin")
ctx.channel = helpers.MockTextChannel(name="admin-channel")

cog = user.UserCog(bot)
await cog.user_stats.callback(cog, ctx)

# Verify respond was called with an embed
ctx.respond.assert_called_once()
call_kwargs = ctx.respond.call_args[1]
embed = call_kwargs["embed"]

# Verify embed fields: 3 members, 2 verified (66.67%), 1 bot
assert embed.title == "HackTheBox Discord User Stats"
fields = {f.name: f.value for f in embed.fields}
assert fields["Members"] == "3"
assert fields["Bots"] == "1"
assert "66.67%" in fields["Verified Members"]

def test_setup(self, bot):
"""Test the setup method of the cog."""
# Invoke the command
Expand Down
2 changes: 1 addition & 1 deletion tests/src/helpers/test_ban.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ async def test__check_member_user(self, bot, guild, user):
bot.get_member_or_user = AsyncMock()
bot.get_member_or_user.return_value = user
response = await _check_member(bot, guild, user, author)
assert await bot.get_member_or_user.called_once_with(guild, user.id)
bot.get_member_or_user.assert_called_once_with(guild, user.id)
assert response is None

@pytest.mark.asyncio
Expand Down