fix: resolve golangci-lint typecheck failures #971
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
james00012
force-pushed
the
fix-golangci-lint-typecheck
branch
7 times, most recently
from
b72fb40 to
d71fb99
Compare
- Add git fetch origin master to ensure ref is available for --new-from-rev - Add go build ./... to populate build cache for typecheck linter - Change modules-download-mode from readonly to mod
james00012
force-pushed
the
fix-golangci-lint-typecheck
branch
from
d71fb99 to
b373fd1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes golangci-lint typecheck failures where dependencies like
smithy,multierror,cli, andyamlare reported as undefined.Root cause:
go.modrequires Go 1.24.0, but CI was using Go 1.22.6,.golangci.ymlspecified Go 1.23, and golangci-lint v1.61.0 doesn't support Go 1.24.Changes:
go/installorb.golangci.ymlto use Go 1.24git fetch origin masterfor--new-from-revcomparisonTest plan