cleanup[BREAKING]: Templatize and cleanup labeling on resources#127
Open
thefirstofthe300 wants to merge 3 commits intomasterfrom
Open
cleanup[BREAKING]: Templatize and cleanup labeling on resources#127thefirstofthe300 wants to merge 3 commits intomasterfrom
thefirstofthe300 wants to merge 3 commits intomasterfrom
Conversation
thefirstofthe300
force-pushed
the
thefirstofthe300/refactor-labeling
branch
2 times, most recently
from
3f2baf7 to
83f5482
Compare
thefirstofthe300
force-pushed
the
thefirstofthe300/refactor-labeling
branch
from
83f5482 to
554d827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We have a bunch of non-standardized labels floating around on multiple different resources. We should standardize all of them.
This will introduce a breaking change due to the changes to the
.spec.selector.matchLabelschanges; however, the generated resources will follow a standard labeling scheme recommended by the k8s project.