Skip to content

Rule EC24#54

Closed
pataluc wants to merge 2 commits intogreen-code-initiative:mainfrom
max-208:24-java
Closed

Rule EC24#54
pataluc wants to merge 2 commits intogreen-code-initiative:mainfrom
max-208:24-java

Conversation

@pataluc
Copy link
Contributor

@pataluc pataluc commented May 30, 2024

Implementing rule EC24 in Java:

  • Adding the rule, the example code and the tests
  • Registering the rule using SNAPSHOT of ecocode-rules-specifications, and updating registrar tests

Fixes green-code-initiative/creedengo-rules-specifications#308

Result:
image

pataluc added 2 commits May 30, 2024 14:15
@pataluc
feat: ✨ EC24 in Java
5b348c7 
Implementing rule EC24 in Java:
- Adding the rule, the example code and the tests
- Registering the rule using SNAPSHOT of ecocode-rules-specifications, and updating registrar tests

Fixes green-code-initiative/creedengo-rules-specifications#308
@pataluc
docs: 📝 Updating CHANGELOG
4c4faf0
@github-actions
Copy link

github-actions bot commented Jun 30, 2024

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Jun 30, 2024
@dedece35
Copy link
Member

dedece35 commented Jul 26, 2024 •
edited
Loading

Hi @pataluc,
thank you for the job but there is already a previous PR for this EC24 rule ... and there are some discussions inside PR about implementation (with the current state of rule description).
but your implementation is a good idea.
I think I will refuse your PR because of duplication with the other previous PR but If you are OK, I will use your idea as part of the new implementation ... please check discussions here : #20

@dedece35 dedece35 marked this pull request as draft July 26, 2024 12:15
@dedece35 dedece35 added 🗃️ rule rule improvment or rule development or bug 🚀 enhancement New feature or request duplicate This issue or pull request already exists and removed stale labels Jul 26, 2024
@dedece35 dedece35 mentioned this pull request Jul 26, 2024
Merged
@github-actions
Copy link

github-actions bot commented Aug 26, 2024

This PR has been automatically marked as stale because it has no activity for 30 days.
Please add a comment if you want to keep the issue open. Thank you for your contributions!

@github-actions github-actions bot added the stale label Aug 26, 2024
@pataluc pataluc closed this May 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@pataluc pataluc

@dedece35 dedece35

Labels

🗃️ rule rule improvment or rule development or bug duplicate This issue or pull request already exists 🚀 enhancement New feature or request stale

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[EC24] java rule not implemented

2 participants

@pataluc @dedece35