fix(tap agent): clean up prometheus gauges on actor stop #887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion stop The UNAGGREGATED_FEES_BY_VERSION gauge was added in the Horizon V2 TAP support commit (8c8dd2b) but was missing cleanup when SenderAllocation actors stop. This caused stale gauge values to persist for closed allocations, affecting Prometheus metrics accuracy. Add remove_label_values call in ActorTerminated handler to clean up the metric with the correct version label (v1/v2) based on sender_type.
Pull Request Test Coverage Report for Build 19989584379Details
💛 - Coveralls |
Collaborator
Author
|
Closing in favor of #888 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
UNAGGREGATED_FEES_BY_VERSION,INVALID_RECEIPT_FEES) whenallocation actors terminate
SENDER_DENIED,ESCROW_BALANCE,SENDER_FEE_TRACKER,MAX_FEE_PER_SENDER,RAV_REQUEST_TRIGGER_VALUE) in SenderAccountpost_stopThis fixes stale gauge values that persisted in Prometheus after allocations closed or senders were removed, which could
cause misleading metric cardinality growth and incorrect dashboard readings.
Joseph Livesey joseph@semiotic.ai