[REFACTOR] Remove custom contains in favor of std lib impl

csrf.go

@@ -254,7 +254,7 @@ func (cs *csrf) ServeHTTP(w http.ResponseWriter, r *http.Request) {
 
 	// HTTP methods not defined as idempotent ("safe") under RFC7231 require
 	// inspection.
-	if !contains(safeMethods, r.Method) {
+	if !slices.Contains(safeMethods, r.Method) {
 		var isPlaintext bool
 		val := r.Context().Value(PlaintextHTTPContextKey)
 		if val != nil {

csrf_test.go

@@ -153,7 +153,7 @@ func TestBadCookie(t *testing.T) {
 	r = createRequest("POST", "/", false)
 
 	// Replace the cookie prefix
-	badHeader := strings.Replace(cookieName+"=", rr.Header().Get("Set-Cookie"), "_badCookie", -1)
+	badHeader := strings.ReplaceAll(cookieName+"=", rr.Header().Get("Set-Cookie"), "_badCookie")
 	r.Header.Set("Cookie", badHeader)
 	r.Header.Set("X-CSRF-Token", token)
 	r.Header.Set("Referer", "http://www.gorillatoolkit.org/")

helpers.go

@@ -189,18 +189,6 @@ func xorToken(a, b []byte) []byte {
 	return res
 }
 
-// contains is a helper function to check if a string exists in a slice - e.g.
-// whether a HTTP method exists in a list of safe methods.
-func contains(vals []string, s string) bool {
-	for _, v := range vals {
-		if v == s {
-			return true
-		}
-	}
-
-	return false
-}
-
 // envError stores a CSRF error in the request context.
 func envError(r *http.Request, err error) *http.Request {
 	return contextSave(r, errorKey, err)

helpers_test.go

@@ -102,7 +102,10 @@ func TestMultipartFormToken(t *testing.T) {
 		t.Fatal(err)
 	}
 
-	mp.Close()
+	err = mp.Close()
+	if err != nil {
+		t.Fatal(err)
+	}
 
 	r = httptest.NewRequest("POST", "/", &b)
 	r.Host = "www.gorillatoolkit.org"