build(deps): bump github.com/goplus/gogen from 1.19.7 to 1.20.2 #615
+23
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [github.com/goplus/gogen](https://github.com/goplus/gogen) from 1.19.7 to 1.20.2. - [Release notes](https://github.com/goplus/gogen/releases) - [Commits](goplus/gogen@v1.19.7...v1.20.2) --- updated-dependencies: - dependency-name: github.com/goplus/gogen dependency-version: 1.20.2 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
dependabot
bot
added
dependencies
Member
|
@xgopilot bump github.com/goplus/gogen from 1.19.7 to 1.20.2 cause these problem! check what happen! --- FAIL: TestFromTestdata (8.82s)
--- PASS: TestFromTestdata/avoidkeyword (0.84s)
--- PASS: TestFromTestdata/enum (0.30s)
--- PASS: TestFromTestdata/forwarddecl (0.32s)
--- PASS: TestFromTestdata/funcrefer (0.38s)
--- FAIL: TestFromTestdata/gettext (0.28s)
--- FAIL: TestFromTestdata/gpgerror (0.31s)
--- PASS: TestFromTestdata/ignoresym (0.30s)
--- PASS: TestFromTestdata/impls (0.34s)
--- PASS: TestFromTestdata/include (0.29s)
--- PASS: TestFromTestdata/isl (0.29s)
--- FAIL: TestFromTestdata/issue507 (0.28s)
--- FAIL: TestFromTestdata/keepcomment (0.28s) |
Contributor
Investigation Complete ✅Root CauseThe gogen v1.20.2 update exposed a bug in The Problem:
The FixUpdated
Result:
Tests FixedThis resolves all 4 failing tests:
Changes PushedCommitted and pushed fix to branch
The CI will now rebuild the LLGo tools with the fix and verify all tests pass. |
…ibility The gogen v1.20.2 update exposed an issue where multi-line C block comments (/* ... */) were being incorrectly split into multiple Go AST Comment nodes. This created invalid Go syntax because each Comment node in Go's AST must be self-contained (either a complete // line or a complete /* */ block). Fixed ParseComment() to: - Keep /* */ block comments as a single Comment node - Preserve existing behavior for // line comments Fixes test failures in: - TestFromTestdata/gettext - TestFromTestdata/gpgerror - TestFromTestdata/issue507 - TestFromTestdata/keepcomment Generated with [codeagent](https://github.com/qbox/codeagent) Co-authored-by: luoliwoshang <51194195+luoliwoshang@users.noreply.github.com>
Member
|
@xgopilot create a issue to link this pr at llcppg to report this depend update bug! and at issue make a mini reprocude for we ,run it from 1.19.7 and 1.20.2 ,to tell us different! |
Contributor
Creating issue to document gogen update bug
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bumps github.com/goplus/gogen from 1.19.7 to 1.20.2.
Release notes
Sourced from github.com/goplus/gogen's releases.
Commits
327dea5Merge pull request #564 from xushiwei/q2dc6aefTest_embedName: anonymous struct04985cbMerge pull request #563 from xushiwei/qd7a6163ClassDefs doca924313TestToTypeAlias: remove no errorecce3d3internal/typesalias go121: support obj7b5e599Test_embedName7411bb7ClassDefs: support embedd52f340Merge pull request #562 from xushiwei/qc6835d6VarDefs.NewAndInit: callInitExprDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebasewill rebase this PR@dependabot recreatewill recreate this PR, overwriting any edits that have been made to it@dependabot mergewill merge this PR after your CI passes on it@dependabot squash and mergewill squash and merge this PR after your CI passes on it@dependabot cancel mergewill cancel a previously requested merge and block automerging@dependabot reopenwill reopen this PR if it is closed@dependabot closewill close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditionswill show all of the ignore conditions of the specified dependency@dependabot ignore this major versionwill close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor versionwill close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependencywill close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)