Add ReadRandom and reimplement NewRandomFromReader using it#89
Open
joewreschnig wants to merge 1 commit intogoogle:masterfrom
Open
Add ReadRandom and reimplement NewRandomFromReader using it#89joewreschnig wants to merge 1 commit intogoogle:masterfrom
ReadRandom and reimplement NewRandomFromReader using it#89joewreschnig wants to merge 1 commit intogoogle:masterfrom
Conversation
Combined with e.g. `bufio.Reader` this provides fast zero-allocation UUID generation if you do not consider heap memory particularly sensitive, without a global state or lock.
|
As mentioned in #88 (comment) this does not address the ever-growing number of constructors in this package. It also means someone intending to use crypto/rand.Rand has to explicitly pass it in order to gain any performance benefit from this. |
There is also the fact that it could sneakily be enabled by some transitive dependency. One of many reasons I chose to throw it out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Combined with e.g.
bufio.Readerthis provides fast zero-allocationUUID generation if you do not consider heap memory particularly
sensitive, without a global state or lock.
I guess this is my proposal re. the discussion about #80/#86/#88. It's faster than both of them and the single new function opens up other optimization possibilities they don't, e.g. if you already have some pathological
[1000]UUIDyou need to fill.I didn't remove the original pool implementation because in the end that's a question of the module's specific commitment to its API compatibility rather than a technical one.