Skip to content

Make type annotation more precise. #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
copybara-service wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make type annotation more precise. #655

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions seqio/vocabularies.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@ def tf_tokenizer(self):
return tf_text.SentencepieceTokenizer(model=self.sp_model)

@property
def vocab_size(self):
def vocab_size(self) -> int:
return self._base_vocab_size

@property
Expand All @@ -454,7 +454,7 @@ def _encode(self, s: str) -> Sequence[int]:
"""
return self.tokenizer.EncodeAsIds(s)

def _decode(self, ids):
def _decode(self, ids) -> str:
"""Decode a list of integers to a python string.

Args:
Expand Down Expand Up @@ -980,7 +980,7 @@ def unk_id(self) -> Optional[int]:
return self._unk_id

@property
def pad_id(self) -> Optional[int]:
def pad_id(self) -> int:
return self._pad_id

@property
Expand All @@ -999,7 +999,7 @@ def tf_tokenizer(self):
return self._tokenizer

@property
def vocab_size(self):
def vocab_size(self) -> int:
return self._base_vocab_size

def _encode(self, s):
Expand Down