feat(a11y): announce dynamic location in Santa tracker button#239
Open
KenTandrian wants to merge 8 commits intogoogle:mainfrom
Open
feat(a11y): announce dynamic location in Santa tracker button#239KenTandrian wants to merge 8 commits intogoogle:mainfrom
KenTandrian wants to merge 8 commits intogoogle:mainfrom
Conversation
Collaborator
Author
Jezzamonn
reviewed
Dec 23, 2025
Collaborator
|
Looks good! We'll need to get the translations updated internally after this PR is merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR fixes an accessibility issue where the "Santa image" button only announced "Santa Claus" without providing context about his current location or status. Screen reader users would land on the button but receive no useful information about where Santa currently is in the world.
Changes
SantaSantaElementto accept a locationLabel property and dynamically update the button text.ModvilTrackerElementto extract the city and region from the data manager and pass it correctly to thesanta-santacomponent.tracker_santa_is_atandtracker_santa_is_heading_towith{{location}}placeholders to ensure proper grammar and translation across languages.en,en-GB,zh-CN,zh-TW,zh-HK,ja, andko.Impacted UI components
modvil-tracker)santa-santa)