fix(a11y): enhance touch target for destination photos#233
Open
KenTandrian wants to merge 5 commits intogoogle:mainfrom
Open
fix(a11y): enhance touch target for destination photos#233KenTandrian wants to merge 5 commits intogoogle:mainfrom
KenTandrian wants to merge 5 commits intogoogle:mainfrom
Conversation
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


This PR fixes an accessibility issue in the "Destination Photos" component where the touch target size for the photos was smaller than the minimum required dimensions (48x48dp on Android / 44x44pt on iOS). Previously, only the attribution text at the bottom was clickable.
Changes
ModvilTrackerPhotoElementto convert the main container (.inner) into an<a>tag. This makes the entire photo card clickable and ensures it meets touch target size requirements.Impacted UI components
modvil-tracker-photo).