Fix Clang warnings #80
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've run into a few "narrowing" issues trying to compile the lib with default settings and got a few errors.
The warnings for ptrdiff_t and int64_t to int32_t are straight forward.
ChatGPT helped me to get Clang to compile ltpf_neon.h without warning/error, but it still requires #pragma diagnostic ignored "-Wconversion" even after splitting the calculation for v32 into simple and verifiable steps.
As a quick compile setup, you could checkout the master branch of BTstack (https://github.com/bluekitchen/btstack/), go to port/libusb, create an xcode folder and run
cmake .. -G Xcode, then open the project and try to compile.