Set previewStabilization to false if video stabilization is set to false.#480
Merged
davidjiagoogle merged 5 commits intomainfrom Feb 20, 2026
Merged
Set previewStabilization to false if video stabilization is set to false.#480davidjiagoogle merged 5 commits intomainfrom
davidjiagoogle merged 5 commits intomainfrom
Conversation
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
temcguir
reviewed
Feb 19, 2026
core/camera/src/main/java/com/google/jetpackcamera/core/camera/CameraSession.kt
Show resolved
Hide resolved
.../camera/src/androidTest/java/com/google/jetpackcamera/core/camera/CameraXCameraSystemTest.kt
Outdated
Show resolved
Hide resolved
.../camera/src/androidTest/java/com/google/jetpackcamera/core/camera/CameraXCameraSystemTest.kt
Outdated
Show resolved
Hide resolved
temcguir
reviewed
Feb 19, 2026
.../camera/src/androidTest/java/com/google/jetpackcamera/core/camera/CameraXCameraSystemTest.kt
Outdated
Show resolved
Hide resolved
temcguir
requested changes
Feb 19, 2026
.../camera/src/androidTest/java/com/google/jetpackcamera/core/camera/CameraXCameraSystemTest.kt
Outdated
Show resolved
Hide resolved
.../camera/src/androidTest/java/com/google/jetpackcamera/core/camera/CameraXCameraSystemTest.kt
Outdated
Show resolved
Hide resolved
.../camera/src/androidTest/java/com/google/jetpackcamera/core/camera/CameraXCameraSystemTest.kt
Outdated
Show resolved
Hide resolved
Collaborator
|
/gemini review |
Contributor
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
temcguir
approved these changes
Feb 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Observed when after creating a preview+imageCapture usecase group for IMAGE_ONLY capture mode, HAL automatically sets video stabilization to ON for both usecases even if JCA doesn't specify it to be on. This is if preivewStabilization isn't set to false specifically, HAL will optimize the experience by doing this.
Added setStabilizationMode_off_imageOnly_updatesCameraState() to test this scenario