Clean up IRObject for custom domain creation. #1947
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
cl/844921062
branch
9 times, most recently
from
1ed30b6 to
bdd08c7
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
cl/844921062
branch
from
bdd08c7 to
ae91fcf
Compare
This includes: 1. Making the data field private and change any external access to use public methods. 2. Makeing IRObject/string conversion standalone instead of member functions. This makes it explicit that the string (i.e. persistent) representation of IRObject is internal and can only be called using the internal namespace. PiperOrigin-RevId: 846782345
copybara-service
bot
force-pushed
the
cl/844921062
branch
from
ae91fcf to
6e4dee4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clean up IRObject for custom domain creation.
This includes:
Making the data field private and change any external access to use public methods.
Makeing IRObject/string conversion standalone instead of member functions.
This makes it explicit that the string (i.e. persistent) representation of IRObject is internal and can only be called using the internal namespace.