Skip to content

chore(docs): reduced size of hero img #545

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zeroasterisk merged 1 commit into from
Jan 24, 2026
Merged

chore(docs): reduced size of hero img #545

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion samples/personalized_learning/Quickstart.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
"\n",
"**Contributed by Google Public Sector's Rapid Innovation Team.**\n",
"\n",
"![Personalized Learning Demo](assets/hero.png)\n",
"![Personalized Learning Demo](assets/hero.jpg)\n",
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good change to reduce the image size. I have a couple of suggestions for improvement:

  1. Accessibility: For better accessibility, the alt text could be more descriptive. Instead of 'Personalized Learning Demo', consider describing what the image visually represents, e.g., 'A screenshot of the Personalized Learning Demo showing a chat interface with interactive flashcards about ATP.' This helps users with screen readers understand the context provided by the image.
  2. Image Optimization: To further reduce file size, consider running the JPG through an optimization tool like Squoosh or ImageOptim. Also, please verify that the JPG compression hasn't introduced visual artifacts, as PNG can sometimes be better for graphics with text.

"\n",
"---\n",
"\n",
Expand Down
2 changes: 1 addition & 1 deletion samples/personalized_learning/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ A full-stack sample demonstrating A2UI's capabilities for building AI-powered ed

**Contributed by Google Public Sector's Rapid Innovation Team.**

![Personalized Learning Demo](assets/hero.png)
![Personalized Learning Demo](assets/hero.jpg)
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Jan 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

This is a good change to reduce the image size. I have a couple of suggestions for improvement:

  1. Accessibility: For better accessibility, the alt text could be more descriptive. Instead of 'Personalized Learning Demo', consider describing what the image visually represents, e.g., 'A screenshot of the Personalized Learning Demo showing a chat interface with interactive flashcards about ATP.' This helps users with screen readers understand the context provided by the image.
  2. Image Optimization: To further reduce file size, consider running the JPG through an optimization tool like Squoosh or ImageOptim. Also, please verify that the JPG compression hasn't introduced visual artifacts, as PNG can sometimes be better for graphics with text.


---

Expand Down
Binary file added samples/personalized_learning/assets/hero.jpg
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed samples/personalized_learning/assets/hero.png
View file
Open in desktop
Binary file not shown.
Loading