[pull] master from golang:master #24
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This CL adds the s390x information to the ABI doc. Update #40724 Cq-Include-Trybots: luci.golang.try:gotip-linux-s390x Change-Id: I1b4b25ef1003e2ab011e1b808aeb1c02288095c2 Reviewed-on: https://go-review.googlesource.com/c/go/+/719460 Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> TryBot-Bypass: David Chase <drchase@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com>
Updates #40724 Change-Id: I9b6c56194b2cbc95c08441dfa1f779ed5efbadb8 Reviewed-on: https://go-review.googlesource.com/c/go/+/719461 Reviewed-by: Mark Freeman <markfreeman@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com>
Update #40724 Change-Id: If8f2574259560b097db29347b2aecb098acef863 Reviewed-on: https://go-review.googlesource.com/c/go/+/719462 Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> Reviewed-by: Keith Randall <khr@google.com>
This adds some initial support for spilling and reloading registers in the new ABI for s390x Update #40724 Change-Id: Icc46a9375454765dea7d03fc4c8f2dbcc87f5f50 Reviewed-on: https://go-review.googlesource.com/c/go/+/719463 Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org>
This CL allow the CALL ops to take variable no of arguments. Update #40724 Change-Id: Ibfa2e98c5051684cae69200c396dfa1edb2878e4 Reviewed-on: https://go-review.googlesource.com/c/go/+/719464 Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
s390x This CL spill arg registers before calling morestack, unspill them after morestack call. It also avoid clobbering the register that could contain incoming argument values. Change registers on s390x to avoid regABI arguments. Update #40724 Change-Id: I67b20552410dd23ef0b86f14b9c5bfed9f9723a6 Reviewed-on: https://go-review.googlesource.com/c/go/+/719421 Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: David Chase <drchase@google.com>
This adds the changes for the register ABI in the runtime functions for s390x platform: - Add spill/unspill functions used by runtime - Add ABIInternal to functions Updates #40724 Change-Id: I6aaeec1d7293b6fec2aa489df90414937b80199e Reviewed-on: https://go-review.googlesource.com/c/go/+/719465 Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com>
This adds ABIInternal to the race function declarations. Update #40724 Change-Id: I827f94fa08240a17a4107a39bca6b4e279dc2530 Reviewed-on: https://go-review.googlesource.com/c/go/+/719422 Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Keith Randall <khr@golang.org> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This adds the regabi support needed for reflect calls makeFuncSub and methodValueCall. Also, It add's archFloat32FromReg and archFloat32ToReg. Update #40724 Change-Id: Ic4b9e30c82f292a24fd2c2b9796cd80a58cecf77 Reviewed-on: https://go-review.googlesource.com/c/go/+/719480 Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Updates #40724 Change-Id: I07a01ac1bda71214f01f4a72e15ab469ef275725 Reviewed-on: https://go-review.googlesource.com/c/go/+/719423 Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Keith Randall <khr@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This allows memmove and memclr to be invoked using the new register ABI on s390x. Update #40724 Change-Id: I2e799aac693ddd693266c156c525d6303060796f Reviewed-on: https://go-review.googlesource.com/c/go/+/719424 Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> Reviewed-by: Keith Randall <khr@google.com>
This adds support for the reg ABI to the byte/string functions for s390x. These are initially under control of the GOEXPERIMENT macro until all changes are in. Updates #40724 Change-Id: Ia3532523fe3a839cc0370d6fe1544972327be514 Reviewed-on: https://go-review.googlesource.com/c/go/+/719481 Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Keith Randall <khr@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@golang.org>
in test func hasRegisterABI
```
goos: linux
goarch: s390x
shortname: minio
pkg: github.com/minio/minio/cmd
│ old │ new
│
│ sec/op │ sec/op vs base
│
DecodehealingTracker-128 1227.5n ± 1% 894.6n ± 1% -27.12%
(p=0.000 n=10)
AppendMsgResyncTargetsInfo-128 8.755n ± 0% 4.942n ± 20% -43.55%
(p=0.000 n=10)
DataUpdateTracker-128 2.075µ ± 1% 1.949µ ± 1% -6.10%
(p=0.000 n=10)
MarshalMsgdataUsageCacheInfo-128 64.32n ± 2% 50.57n ± 6% -21.37%
(p=0.000 n=10)
geomean 194.6n 144.5n -25.76%
shortname: gonum_topo
pkg: gonum.org/v1/gonum/graph/topo
│ old │ new
│
│ sec/op │ sec/op vs base
│
TarjanSCCGnp_10_tenth-128 8.733µ ± 1% 6.953µ ± 2% -20.38%
(p=0.000 n=10)
TarjanSCCGnp_1000_half-128 101.60m ± 0% 72.79m ± 1% -28.36%
(p=0.000 n=10)
geomean 942.0µ 711.4µ -24.48%
shortname: gonum_traverse
pkg: gonum.org/v1/gonum/graph/traverse
│ old │
new │
│ sec/op │ sec/op vs
base │
WalkAllBreadthFirstGnp_10_tenth-128 3.871µ ± 2% 3.242µ ± 2%
-16.25% (p=0.000 n=10)
WalkAllBreadthFirstGnp_1000_tenth-128 11.879m ± 1% 9.034m ± 1%
-23.95% (p=0.000 n=10)
geomean 214.4µ 171.1µ
-20.19%
hortname: ericlagergren_decimal
pkg: github.com/ericlagergren/decimal/benchmarks
│ old │
new │
│ sec/op │ sec/op vs
base │
Pi/foo=ericlagergren_(Go)/prec=100-128 181.6µ ± 0% 145.3µ ± 2%
-20.01% (p=0.000 n=10)
Pi/foo=ericlagergren_(GDA)/prec=100-128 356.4µ ± 1% 298.2µ ± 2%
-16.33% (p=0.000 n=10)
Pi/foo=shopspring/prec=100-128 426.5µ ± 2% 403.1µ ± 4%
-5.47% (p=0.000 n=10)
Pi/foo=apmckinlay/prec=100-128 4.943µ ± 0% 3.903µ ± 1%
-21.03% (p=0.000 n=10)
Pi/foo=go-inf/prec=100-128 132.1µ ± 4% 119.7µ ± 3%
-9.37% (p=0.000 n=10)
Pi/foo=float64/prec=100-128 4.210µ ± 0% 4.210µ ± 0%
~ (p=0.269 n=10)
geomean 65.07µ 57.02µ
-12.37%
shortname: uber_tally
pkg: github.com/uber-go/tally
│ old │ new
│
│ sec/op │ sec/op vs base
│
ScopeTaggedNoCachedSubscopes-128 3.511µ ± 12% 3.067µ ± 6% -12.63%
(p=0.000 n=10)
HistogramAllocation-128 1.085µ ± 15% 1.011µ ± 6% -6.87%
(p=0.001 n=10)
geomean 1.952µ 1.760µ -9.80%
shortname: uber_zap
pkg: go.uber.org/zap/zapcore
│ old │
new │
│ sec/op │
sec/op vs base │
BufferedWriteSyncer/write_file_with_buffer-128 119.0n ± 3% 101.7n
± 5% -14.54% (p=0.000 n=10)
MultiWriteSyncer/2_discarder-128 13.320n ± 34% 9.410n
± 28% -29.35% (p=0.005 n=10)
MultiWriteSyncer/4_discarder-128 10.830n ± 10% 8.883n
± 8% -17.98% (p=0.000 n=10)
MultiWriteSyncer/4_discarder_with_buffer-128 119.0n ± 5% 104.1n
± 4% -12.52% (p=0.000 n=10)
WriteSyncer/write_file_with_no_buffer-128 1.393µ ± 10% 1.409µ
± 7% ~ (p=1.000 n=10)
ZapConsole-128 796.9n ± 14% 722.2n
± 7% -9.37% (p=0.003 n=10)
JSONLogMarshalerFunc-128 1.233µ ± 5% 1.095µ
± 8% -11.20% (p=0.002 n=10)
ZapJSON-128 560.7n ± 9% 547.9n
± 6% ~ (p=0.289 n=10)
StandardJSON-128 628.7n ± 7% 566.2n
± 7% -9.95% (p=0.001 n=10)
Sampler_Check/7_keys-128 8.068n ± 17% 8.232n
± 4% ~ (p=0.382 n=10)
Sampler_Check/50_keys-128 4.064n ± 13% 3.610n
± 17% ~ (p=0.063 n=10)
Sampler_Check/100_keys-128 6.559n ± 5% 6.386n
± 6% ~ (p=0.063 n=10)
Sampler_CheckWithHook/7_keys-128 40.04n ± 3% 36.82n
± 6% -8.05% (p=0.000 n=10)
Sampler_CheckWithHook/50_keys-128 39.48n ± 3% 36.48n
± 4% -7.61% (p=0.000 n=10)
Sampler_CheckWithHook/100_keys-128 41.27n ± 5% 40.85n
± 9% ~ (p=0.353 n=10)
TeeCheck-128 135.2n ± 11% 128.2n
± 10% ~ (p=0.190 n=10)
geomean 77.98n 70.91n
-9.07%
shortname: spexs2
pkg: github.com/egonelbre/spexs2/_benchmark
│ old │ new │
│ sec/op │ sec/op vs base │
Run/10k/1-128 21.58 ± 2% 19.68 ± 12% -8.84% (p=0.015 n=10)
Run/10k/16-128 4.539 ± 6% 4.063 ± 7% -10.48% (p=0.000 n=10)
geomean 9.898 8.941 -9.67%
```
Update #40724
Change-Id: I3c3c02e766e2f7402e385eddadbfe09361d82387
Reviewed-on: https://go-review.googlesource.com/c/go/+/719482
Reviewed-by: Vishwanatha HD <vishwanatha.hd@ibm.com>
Reviewed-by: Keith Randall <khr@google.com>
Reviewed-by: Michael Pratt <mpratt@google.com>
Reviewed-by: Keith Randall <khr@golang.org>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
So the simd package does not exist, instead of existing as an empty package, if the goexperiment is not enabled. Unfortunately the simd package developers have to run GOEXPERIMENT=simd go generate, especially if one is not on an AMD64 machine. But that command is still simple enough, not too bad. Change-Id: I632ce92ecb72e208212e294d8b3448b43fd01eef Reviewed-on: https://go-review.googlesource.com/c/go/+/723802 Reviewed-by: Junyang Shao <shaojunyang@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
When using `any` as param or return type of an exported
function, we currently have the error `unrecognized Go
type any`. `any` is an alias of `interface{}` which is
already supported.
This would avoid such change: php/frankenphp#1976
Fixes #76340
Change-Id: I301838ff72e99ae78b035a8eff2405f6a145ed1a
GitHub-Last-Rev: 7dfbccf
GitHub-Pull-Request: #76325
Reviewed-on: https://go-review.googlesource.com/c/go/+/720960
Reviewed-by: Mark Freeman <markfreeman@google.com>
Auto-Submit: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Keith Randall <khr@golang.org>
Reviewed-by: Ian Lance Taylor <iant@golang.org>
Reviewed-by: Keith Randall <khr@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Preparing for merge to the main branch. Will reenable on the branch. Change-Id: Iac77dfb90498cf6eb60f79930a53179f130b7508 Reviewed-on: https://go-review.googlesource.com/c/go/+/723940 Reviewed-by: Junyang Shao <shaojunyang@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
The documentation for GOTRACEBACK says that "single" is the default where the stack trace for only a single routine is printed except that it prints all stack traces if: there is no current goroutine or the failure is internal to the run-time. In the runtime, there are two types of panics: throwTypeUser and throwTypeRuntime. The latter more clearly corresponds to a "failure [that] is internal to the run-time", while the former corresponds to a problem trigger due to a user mistake. Thus, a user-triggered panic (e.g., concurrent map access) should not result in a dump of all stack traces. Fixes #68019 Change-Id: I9b02f82535ddb9fd666f7158e2e4ee10f235646a Reviewed-on: https://go-review.googlesource.com/c/go/+/649535 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Reviewed-by: Michael Knyszek <mknyszek@google.com>
Merge List: + 2025-11-24 02d1f3a runtime: respect GOTRACEBACK for user-triggered runtime panics + 2025-11-24 a593ca9 runtime/cgo: add support for `any` param and return type + 2025-11-24 8955291 cmd/compile, internal/buildcfg: enable regABI on s390x, and add s390x + 2025-11-24 2fe0ba8 internal/bytealg: port bytealg functions to reg ABI on s390x + 2025-11-24 4529c8f runtime: port memmove, memclr to register ABI on s390x + 2025-11-24 58a48a3 internal/runtime/syscall: Syscall changes for s390x regabi + 2025-11-24 2a185fa reflect, runtime: add reflect support for regabi on s390x + 2025-11-24 e92d296 runtime: mark race functions on s390x as ABIInternal + 2025-11-24 41af98e runtime: add runtime changes for register ABI on s390x + 2025-11-24 85e6080 cmd/internal/obj: set morestack arg spilling and regabi prologue on s390x + 2025-11-24 2469741 cmd/compile: update s390x CALL* ops + 2025-11-24 81242d0 cmd/compile/internal/s390x: add initial spill support + 2025-11-24 73b6aa0 cmd/compile/internal: add register ABI information for s390x + 2025-11-24 1036f6f internal/abi: define s390x ABI constants + 2025-11-24 2e5d12a cmd/compile: document register-based ABI for s390x Change-Id: I57b4ae6f9b65d99958b9fe5974205770e18f7788
It's a fairly well-known invariant that each object must exist in the object map and cannot be nil. This change just shortens a check of that invariant. Change-Id: Id15c158c3a9ad91cdc230fb0b84eb69b2451cbdc Reviewed-on: https://go-review.googlesource.com/c/go/+/722061 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Mark Freeman <markfreeman@google.com> Reviewed-by: Robert Griesemer <gri@google.com>
Merge List: + 2025-11-24 e704b09 go/types, types2: shorten object map assertion Change-Id: Ie45f971d2872c6b7f8f62d61e4d307ccf52a6546
This commit is a REVERSE MERGE. It merges dev.simd back into its parent branch, master. The development of simd will continue on (only) dev.simd, and it will be merged to the master branch when necessary. Merge List: + 2025-11-24 7d65463 [dev.simd] all: merge master (e704b09) into dev.simd + 2025-11-24 afd1721 [dev.simd] all: merge master (02d1f3a) into dev.simd + 2025-11-24 a991488 [dev.simd] internal/buildcfg: don't enable SIMD experiment by default + 2025-11-24 61a5a6b [dev.simd] simd: add goexperiment tag to generate.go + 2025-11-24 f045ed4 [dev.simd] go/doc/comment: don't include experimental packages in std list + 2025-11-24 220d73c [dev.simd] all: merge master (8dd5b13) into dev.simd + 2025-11-24 0c69e77 Revert "[dev.simd] internal/runtime/gc: add simd package based greentea kernels" + 2025-11-21 da92168 [dev.simd] internal/runtime/gc: add simd package based greentea kernels + 2025-11-21 3fdd183 [dev.simd] cmd/compile, simd: update conversion API names + 2025-11-21 d3a0321 [dev.simd] cmd/compile: fix incorrect mapping of SHA256MSG2128 + 2025-11-20 74ebdd2 [dev.simd] simd, cmd/compile: add more element types for Select128FromPair + 2025-11-20 4d26d66 [dev.simd] simd: fix signatures for PermuteConstant* methods + 2025-11-20 e3d4645 [dev.simd] all: merge master (ca37d24) into dev.simd + 2025-11-20 95b4ad5 [dev.simd] simd: reorganize internal tests so that simd does not import testing + 2025-11-18 3fe246a [dev.simd] simd: make 'go generate' generate everything + 2025-11-18 cf45adf [dev.simd] simd: move template code generator into _gen + 2025-11-18 19b4a30 [dev.simd] simd/_gen/simdgen: remove outdated asm.yaml.toy + 2025-11-18 9461db5 [dev.simd] simd: fix comment in file generator + 2025-11-18 4004ff3 [dev.simd] simd: remove FlattenedTranspose from exports + 2025-11-18 896f293 [dev.simd] cmd/compile, simd: change DotProductQuadruple and add peepholes + 2025-11-18 be9c50c [dev.simd] cmd/compile, simd: change SHA ops names and types + 2025-11-17 0978935 [dev.simd] cmd/compile, simd: change AES op names and add missing size + 2025-11-17 95871e4 [dev.simd] cmd/compile, simd: add VPALIGNR + 2025-11-17 934dbce [dev.simd] simd: update CPU feature APIs + 2025-11-17 e4d9484 [dev.simd] cmd/compile: fix unstable output + 2025-11-13 d7a0c45 [dev.simd] all: merge master (57362e9) into dev.simd + 2025-11-11 86b4fe3 [dev.simd] cmd/compile: add masked merging ops and optimizations + 2025-11-10 771a1dc [dev.simd] cmd/compile: add peepholes for all masked ops and bug fixes + 2025-11-10 972732b [dev.simd] simd, cmd/compile: remove move from API + 2025-11-10 bf77323 [dev.simd] simd: put unexported methods to another file + 2025-11-04 fe04065 [dev.simd] simd/_gen: fix sorting ops slices + 2025-10-29 e452f4a [dev.simd] cmd/compile: enhance inlining for closure-of-SIMD + 2025-10-27 ca1264a [dev.simd] test: add some trickier cases to ternary-boolean simd test + 2025-10-24 f6b4711 [dev.simd] cmd/compile, simd: add rewrite to convert logical expression trees into TERNLOG instructions + 2025-10-24 cf7c1a4 [dev.simd] cmd/compile, simd: add SHA features + 2025-10-24 2b8eded [dev.simd] simd/_gen: parse SHA features from XED + 2025-10-24 c75965b [dev.simd] simd: added String() method to SIMD vectors. + 2025-10-22 d03634f [dev.simd] cmd/compile, simd: add definitions for VPTERNLOG[DQ] + 2025-10-20 20b3339 [dev.simd] simd: add AES feature check + 2025-10-14 fc3bc49 [dev.simd] simd: clean up mask load comments + 2025-10-14 416332d [dev.simd] cmd/compile, simd: update DotProd to DotProduct + 2025-10-14 647c790 [dev.simd] cmd/compile: peephole simd mask load/stores from bits + 2025-10-14 2e71cf1 [dev.simd] cmd/compile, simd: remove mask load and stores + 2025-10-13 c4fbf3b [dev.simd] simd/_gen: add mem peephole with feat mismatches + 2025-10-13 ba72ee0 [dev.simd] cmd/compile: more support for cpufeatures + 2025-10-09 be57d94 [dev.simd] simd: add emulated Not method + 2025-10-07 d2270bc [dev.simd] cmd/compile: track which CPU features are in scope + 2025-10-03 48756ab [dev.simd] cmd/compile: inliner tweaks to favor simd-handling functions + 2025-10-03 fb1749a [dev.simd] all: merge master (adce7f1) into dev.simd + 2025-09-30 703a5fb [dev.simd] cmd/compile, simd: add AES instructions + 2025-09-29 1c961c2 [dev.simd] simd: use new data movement instructions to do "fast" transposes + 2025-09-26 fe4af1c [dev.simd] simd: repair broken comments in generated ops_amd64.go + 2025-09-26 ea3b2ec [dev.simd] cmd/compile, simd: add 64-bit select-from-pair methods + 2025-09-26 25c36b9 [dev.simd] simd, cmd/compile: add 128 bit select-from-pair + 2025-09-26 f0e281e [dev.simd] cmd/compile: don't require single use for SIMD load/store folding + 2025-09-26 b4d1e01 [dev.simd] cmd/compile: remove unnecessary code from early simd prototype + 2025-09-26 578777b [dev.simd] cmd/compile: make condtion of CanSSA smarter for SIMD fields + 2025-09-26 c28b2a0 [dev.simd] simd: generalize select-float32-from-pair + 2025-09-25 a693ae1 [dev.simd] all: merge master (d70ad4e) into dev.simd + 2025-09-25 5a78e1a [dev.simd] simd, cmd/compile: mark simd vectors uncomparable + 2025-09-23 bf00f5d [dev.simd] simd, cmd/compile: added simd methods for VSHUFP[DS] + 2025-09-23 8e60fee [dev.simd] cmd/compile: improve slicemask removal + 2025-09-23 2b50ffe [dev.simd] cmd/compile: remove stores to unread parameters + 2025-09-23 2d8cb80 [dev.simd] all: merge master (9b2d39b) into dev.simd + 2025-09-22 63a09d6 [dev.simd] cmd/compile: fix SIMD const rematerialization condition + 2025-09-20 2ca96d2 [dev.simd] cmd/compile: enhance prove to infer bounds in slice len/cap calculations + 2025-09-19 c0f031f [dev.simd] cmd/compile: spill the correct SIMD register for morestack + 2025-09-19 58fa1d0 [dev.simd] cmd/compile: enhance the chunked indexing case to include reslicing + 2025-09-18 7ae0eb2 [dev.simd] cmd/compile: remove Add32x4 generic op + 2025-09-18 31b664d [dev.simd] cmd/compile: widen index for simd intrinsics jumptable + 2025-09-18 e34ad6d [dev.simd] cmd/compile: optimize VPTEST for 2-operand cases + 2025-09-18 f1e3651 [dev.simd] cmd/compile, simd: add VPTEST + 2025-09-18 d975116 [dev.simd] cmd/compile: handle rematerialized op for incompatible reg constraint + 2025-09-18 4eb5c6e [dev.simd] cmd/compile, simd/_gen: add rewrite for const load ops + 2025-09-18 443b7ae [dev.simd] cmd/compile, simd/_gen: make rewrite rules consistent on CPU Features + 2025-09-16 bdd30e2 [dev.simd] all: merge master (ca0e035) into dev.simd + 2025-09-16 0e590a5 [dev.simd] cmd/compile: use the right type for spill slot + 2025-09-15 dabe2bb [dev.simd] cmd/compile: fix holes in mask peepholes + 2025-09-12 3ec0b25 [dev.simd] cmd/compile, simd/_gen/simdgen: add const load mops + 2025-09-12 1e5631d [dev.simd] cmd/compile: peephole simd load + 2025-09-11 48f366d [dev.simd] cmd/compile: add memop peephole rules + 2025-09-11 9a349f8 [dev.simd] all: merge master (cf5e993) into dev.simd + 2025-09-11 5a0446d [dev.simd] simd/_gen/simdgen, cmd/compile: add memory op machine ops + 2025-09-08 c39b2fd [dev.simd] cmd/compile, simd: add VPLZCNT[DQ] + 2025-09-07 832c1f7 [dev.simd] cmd/compile: enhance prove to deal with double-offset IsInBounds checks + 2025-09-06 0b32335 [dev.simd] simd/_gen/simdgen: merge memory ops + 2025-09-06 f42c926 [dev.simd] simd/_gen/simdgen: parse memory operands + 2025-09-05 356c48d [dev.simd] cmd/compile, simd: add ClearAVXUpperBits + 2025-09-03 7c8b911 [dev.simd] all: merge master (4c4cefc) into dev.simd + 2025-09-02 9125351 [dev.simd] internal/cpu: report AVX1 and 2 as supported on macOS 15 Rosetta 2 + 2025-09-02 b509516 [dev.simd] simd, cmd/compile: add Interleave{Hi,Lo} (VPUNPCK*) + 2025-09-02 6890aa2 [dev.simd] cmd/compile: add instructions and rewrites for scalar-> vector moves + 2025-08-24 5ebe2d0 [dev.simd] simd: correct SumAbsDiff documentation + 2025-08-22 a5137ec [dev.simd] cmd/compile: sample peephole optimization for SIMD broadcast + 2025-08-22 8371461 [dev.simd] cmd/compile: remove VPADDD4 + 2025-08-22 4a3ea14 [dev.simd] cmd/compile: correct register mask of some AVX512 ops + 2025-08-22 8d87483 [dev.simd] cmd/compile: use X15 for zero value in AVX context + 2025-08-22 4c311aa [dev.simd] cmd/compile: ensure the whole X15 register is zeroed + 2025-08-22 baea0c7 [dev.simd] cmd/compile, simd: complete AVX2? u?int shuffles + 2025-08-22 fa1e78c [dev.simd] cmd/compile, simd: make Permute 128-bit use AVX VPSHUFB + 2025-08-22 bc217d4 [dev.simd] cmd/compile, simd: add packed saturated u?int conversions + 2025-08-22 4fa23b0 [dev.simd] cmd/compile, simd: add saturated u?int conversions + 2025-08-21 3f6bab5 [dev.simd] simd: move tests to a subdirectory to declutter "simd" + 2025-08-21 aea0a5e [dev.simd] simd/_gen/unify: improve envSet doc comment + 2025-08-21 7fdb1da [dev.simd] cmd/compile, simd: complete truncating u?int conversions. + 2025-08-21 f4c41d9 [dev.simd] cmd/compile, simd: complete u?int widening conversions + 2025-08-21 6af8881 [dev.simd] simd: reorganize cvt rules + 2025-08-21 58cfc2a [dev.simd] cmd/compile, simd: add VPSADBW + 2025-08-21 f7c6fa7 [dev.simd] simd/_gen/unify: fix some missing environments + 2025-08-20 7c84e98 [dev.simd] cmd/compile: rewrite to elide Slicemask from len==c>0 slicing + 2025-08-20 cf31b15 [dev.simd] simd, cmd/compile: added .Masked() peephole opt for many operations. + 2025-08-20 1334285 [dev.simd] simd: template field name cleanup in genfiles + 2025-08-20 af6475d [dev.simd] simd: add testing hooks for size-changing conversions + 2025-08-20 ede64cf [dev.simd] simd, cmd/compile: sample peephole optimization for .Masked() + 2025-08-20 103b6e3 [dev.simd] all: merge master (9de69f6) into dev.simd + 2025-08-20 728ac3e [dev.simd] simd: tweaks to improve test disassembly + 2025-08-20 4fce49b [dev.simd] simd, cmd/compile: add widening unsigned converts 8->16->32 + 2025-08-19 0f660d6 [dev.simd] simd: make OpMasked machine ops only + 2025-08-19 a034826 [dev.simd] simd, cmd/compile: implement ToMask, unexport asMask. + 2025-08-18 8ccd6c2 [dev.simd] simd, cmd/compile: mark BLEND instructions as not-zero-mask + 2025-08-18 9a934d5 [dev.simd] cmd/compile, simd: added methods for "float" GetElem + 2025-08-15 7380213 [dev.simd] cmd/compile: make move/load/store dependent only on reg and width + 2025-08-15 908e3e8 [dev.simd] cmd/compile: make (most) move/load/store lowering use reg and width only + 2025-08-14 9783f86 [dev.simd] cmd/compile: accounts rematerialize ops's output reginfo + 2025-08-14 a4ad417 [dev.simd] all: merge master (924fe98) into dev.simd + 2025-08-13 8b90d48 [dev.simd] simd/_gen/simdgen: rewrite etetest.sh + 2025-08-13 b7c8698 [dev.simd] simd/_gen: migrate simdgen from x/arch + 2025-08-13 257c135 [dev.simd] go/types: exclude simd/_gen module from TestStdlib + 2025-08-13 858a8d2 [dev.simd] simd: reorganize/rename generated emulation files + 2025-08-13 2080415 [dev.simd] simd: add emulations for missing AVX2 comparisons + 2025-08-13 ddb689c [dev.simd] simd, cmd/compile: generated code for Broadcast + 2025-08-13 e001300 [dev.simd] cmd/compile: fix LoadReg so it is aware of register target + 2025-08-13 d5dea86 [dev.simd] cmd/compile: fix isIntrinsic for methods; fix fp <-> gp moves + 2025-08-13 08ab8e2 [dev.simd] cmd/compile: generated code from 'fix generated rules for shifts' + 2025-08-11 702ee2d [dev.simd] cmd/compile, simd: update generated files + 2025-08-11 e33eb1a [dev.simd] cmd/compile, simd: update generated files + 2025-08-11 667add4 [dev.simd] cmd/compile, simd: update generated files + 2025-08-11 1755c29 [dev.simd] cmd/compile, simd: update generated files + 2025-08-11 2fd49d8 [dev.simd] simd: imm doc improve + 2025-08-11 ce0e803 [dev.simd] cmd/compile: keep track of multiple rule file names in ssa/_gen + 2025-08-11 38b76bf [dev.simd] cmd/compile, simd: jump table for imm ops + 2025-08-08 94d7235 [dev.simd] simd: add emulations for bitwise ops and for mask/merge methods + 2025-08-07 8eb5f60 [dev.simd] cmd/compile, simd: API interface fixes + 2025-08-07 b226bcc [dev.simd] cmd/compile, simd: add value conversion ToBits for mask + 2025-08-06 5b0ef7f [dev.simd] cmd/compile, simd: add Expand + 2025-08-06 d3cf582 [dev.simd] cmd/compile, simd: (Set|Get)(Lo|Hi) + 2025-08-05 7ca3459 [dev.simd] simd, cmd/compile: generated files to add 'blend' and 'blendMasked' + 2025-08-05 82d056d [dev.simd] cmd/compile: add ShiftAll immediate variant + 2025-08-04 775fb52 [dev.simd] all: merge master (7a1679d) into dev.simd + 2025-08-04 6b9b59e [dev.simd] simd, cmd/compile: rename some methods + 2025-08-04 d375b95 [dev.simd] simd: move lots of slice functions and methods to generated code + 2025-08-04 3f92aa1 [dev.simd] cmd/compile, simd: make bitwise logic ops available to all u?int vectors + 2025-08-04 c2d775d [dev.simd] cmd/compile, simd: change PairDotProdAccumulate to AddDotProd + 2025-08-04 2c25f3e [dev.simd] cmd/compile, simd: change Shift*AndFillUpperFrom to Shift*Concat + 2025-08-01 c25e5c8 [dev.simd] cmd/compile: generated code for K-mask-register slice load/stores + 2025-08-01 1ac5f35 [dev.simd] cmd/compile: opcodes and rules and code generation to enable AVX512 masked loads/stores + 2025-08-01 f39711a [dev.simd] cmd/compile: test for int-to-mask conversion + 2025-08-01 08bec02 [dev.simd] cmd/compile: add register-to-mask moves, other simd glue + 2025-08-01 09ff25e [dev.simd] simd: add tests for simd conversions to Int32/Uint32. + 2025-08-01 a24ffe3 [dev.simd] simd: modify test generation to make it more flexible + 2025-08-01 ec5c20b [dev.simd] cmd/compile: generated simd code to add some conversions + 2025-08-01 e62e377 [dev.simd] cmd/compile, simd: generated code from repaired simdgen sort + 2025-08-01 761894d [dev.simd] simd: add partial slice load/store for 32/64-bits on AVX2 + 2025-08-01 acc1492 [dev.simd] cmd/compile: Generated code for AVX2 SIMD masked load/store + 2025-08-01 a0b87a7 [dev.simd] cmd/compile: changes for AVX2 SIMD masked load/store + 2025-08-01 8856851 [dev.simd] simd: move test generation into Go repo + 2025-07-31 6f7a116 [dev.simd] cmd/compile, simd: support store to bits for mask + 2025-07-21 41054cd [dev.simd] simd, internal/cpu: support more AVX CPU Feature checks + 2025-07-21 957f06c [dev.simd] cmd/compile, simd: support load from bits for mask + 2025-07-21 f0e9dc0 [dev.simd] cmd/compile: fix opLen(2|3)Imm8_2I intrinsic function + 2025-07-17 03a3887 [dev.simd] simd: clean up masked op doc + 2025-07-17 c61743e [dev.simd] cmd/compile, simd: reorder PairDotProdAccumulate + 2025-07-15 ef5f6cc [dev.simd] cmd/compile: adjust param order for AndNot + 2025-07-15 6d10680 [dev.simd] cmd/compile, simd: add Compress + 2025-07-15 17baae7 [dev.simd] simd: default mask param's name to mask + 2025-07-15 01f7f57 [dev.simd] cmd/compile, simd: add variable Permute + 2025-07-14 f5f4275 [dev.simd] cmd/compile, simd: add VDPPS + 2025-07-14 08ffd66 [dev.simd] simd: updates CPU Feature in doc + 2025-07-14 3f78972 [dev.simd] cmd/compile: mark SIMD types non-fat + 2025-07-11 b69622b [dev.simd] cmd/compile, simd: adjust Shift.* operations + 2025-07-11 4993a91 [dev.simd] simd: change imm param name to constant + 2025-07-11 bbb6dcc [dev.simd] simd: fix documentations + 2025-07-11 1440ff7 [dev.simd] cmd/compile: exclude simd vars from merge local + 2025-07-11 ccb43dc [dev.simd] cmd/compile: add VZEROUPPER and VZEROALL inst + 2025-07-11 21596f2 [dev.simd] all: merge master (88cf0c5) into dev.simd + 2025-07-10 ab7f839 [dev.simd] cmd/compile: fix maskreg/simdreg chaos + 2025-07-09 47b07a8 [dev.simd] cmd/compile, simd: fix Int64x2 Greater output type to mask + 2025-07-09 08cd62e [dev.simd] cmd/compile: remove X15 from register mask + 2025-07-09 9ea33ed [dev.simd] cmd/compile: output of simd generator, more ... rewrite rules + 2025-07-09 aab8b17 [dev.simd] cmd/compile, simd: Int64x2 Greater and Uint* Equal + 2025-07-09 8db7f41 [dev.simd] cmd/compile: use upper registers for AVX512 simd ops + 2025-07-09 574854f [dev.simd] runtime: save Z16-Z31 registers in async preempt + 2025-07-09 5429328 [dev.simd] cmd/compile: change register mask names for simd ops + 2025-07-09 029d7ec [dev.simd] cmd/compile, simd: rename Masked$OP to $(OP)Masked. + 2025-07-09 983e81c [dev.simd] simd: rename stubs_amd64.go to ops_amd64.go + 2025-07-08 56ca676 [dev.simd] cmd/compile, simd: remove FP bitwise logic operations. + 2025-07-08 0870ed0 [dev.simd] cmd/compile: make compares between NaNs all false. + 2025-07-08 24f2b8a [dev.simd] simd: {Int,Uint}{8x{16,32},16x{8,16}} subvector loads/stores from slices. + 2025-07-08 2bb45cb [dev.simd] cmd/compile: minor tweak for race detector + 2025-07-07 43a61ae [dev.simd] cmd/compile: add EXTRACT[IF]128 instructions + 2025-07-07 292db9b [dev.simd] cmd/compile: add INSERT[IF]128 instructions + 2025-07-07 d8fa853 [dev.simd] cmd/compile: make regalloc simd aware on copy + 2025-07-07 dfd75f8 [dev.simd] cmd/compile: output of simdgen with invariant type order + 2025-07-04 72c39ef [dev.simd] cmd/compile: fix the "always panic" code to actually panic + 2025-07-01 1ee72a1 [dev.simd] internal/cpu: add GFNI feature check + 2025-06-30 0710cce [dev.simd] runtime: remove write barrier in xRegRestore + 2025-06-30 59846af [dev.simd] cmd/compile, simd: cleanup operations and documentations + 2025-06-30 f849225 [dev.simd] all: merge master (740857f) into dev.simd + 2025-06-30 9eeb1e7 [dev.simd] runtime: save AVX2 and AVX-512 state on asynchronous preemption + 2025-06-30 426cf36 [dev.simd] runtime: save scalar registers off stack in amd64 async preemption + 2025-06-30 ead249a [dev.simd] cmd/compile: reorder operands for some simd operations + 2025-06-30 55665e1 [dev.simd] cmd/compile: undoes reorder transform in prior commit, changes names + 2025-06-26 10c9621 [dev.simd] cmd/compile, simd: add galois field operations + 2025-06-26 e61ebfc [dev.simd] cmd/compile, simd: add shift operations + 2025-06-26 35b8cf7 [dev.simd] cmd/compile: tweak sort order in generator + 2025-06-26 7fadfa9 [dev.simd] cmd/compile: add simd VPEXTRA* + 2025-06-26 0d8cb89 [dev.simd] cmd/compile: support simd(imm,fp) returns gp + 2025-06-25 f4a7c12 [dev.simd] all: merge master (f8ccda2) into dev.simd + 2025-06-25 4fda27c [dev.simd] cmd/compile: glue codes for Shift and Rotate + 2025-06-24 61c1183 [dev.simd] simd: add test wrappers + 2025-06-23 e324880 [dev.simd] cmd/compile: make simd regmask naming more like existing conventions + 2025-06-23 1fa4bcf [dev.simd] simd, cmd/compile: generated code for VPINSR[BWDQ], and test + 2025-06-23 dd63b7a [dev.simd] simd: add AVX512 aggregated check + 2025-06-23 0cdb269 [dev.simd] simd: add tests for intrinsic used as a func value and via reflection + 2025-06-23 88c013d [dev.simd] cmd/compile: generate function body for bodyless intrinsics + 2025-06-20 a8669c7 [dev.simd] sync: correct the type of runtime_StoreReluintptr + 2025-06-20 7c6ac35 [dev.simd] cmd/compile: add simdFp1gp1fp1Imm8 helper to amd64 code generation + 2025-06-20 4150372 [dev.simd] cmd/compile: don't treat devel compiler as a released compiler + 2025-06-18 1b87d52 [dev.simd] cmd/compile: add fp1gp1fp1 register mask for AMD64 + 2025-06-18 1313521 [dev.simd] cmd/compile: remove fused mul/add/sub shapes. + 2025-06-17 1be5eb2 [dev.simd] cmd/compile: fix signature error of PairDotProdAccumulate. + 2025-06-17 3a4d10b [dev.simd] cmd/compile: removed a map iteration from generator; tweaked type order + 2025-06-17 21d6573 [dev.simd] cmd/compile: alphabetize SIMD intrinsics + 2025-06-16 ee1d9f3 [dev.simd] cmd/compile: reorder stubs + 2025-06-13 6c50c8b [dev.simd] cmd/compile: move simd helpers into compiler, out of generated code + 2025-06-13 7392dfd [dev.simd] cmd/compile: generated simd*ops files weren't up to date + 2025-06-13 00a8dac [dev.simd] cmd/compile: remove unused simd intrinsics "helpers" + 2025-06-13 b9a5487 cmd/compile: add up-to-date test for generated files + 2025-06-13 ca01eab [dev.simd] cmd/compile: add fused mul add sub ops + 2025-06-13 ded6e0a [dev.simd] cmd/compile: add more dot products + 2025-06-13 3df41c8 [dev.simd] simd: update documentations + 2025-06-13 9ba7db3 [dev.simd] cmd/compile: add dot product ops + 2025-06-13 34a9cde [dev.simd] cmd/compile: add round simd ops + 2025-06-13 5289e0f [dev.simd] cmd/compile: updates simd ordering and docs + 2025-06-13 c81cb05 [dev.simd] cmd/compile: add simdGen prog writer + 2025-06-13 9b9af3d [dev.simd] internal/cpu: add AVX-512-CD and DQ, and derived "basic AVX-512" + 2025-06-13 dfa6c74 [dev.simd] runtime: eliminate global state in mkpreempt.go + 2025-06-10 b2e8ddb [dev.simd] all: merge master (773701a) into dev.simd + 2025-06-09 884f646 [dev.simd] cmd/compile: add fp3m1fp1 shape to regalloc + 2025-06-09 6bc3505 [dev.simd] cmd/compile: add fp3fp1 regsiter shape + 2025-06-05 2eaa5a0 [dev.simd] simd: add functions+methods to load-from/store-to slices + 2025-06-05 8ecbd59 [dev.simd] cmd/compile: generated codes for amd64 SIMD + 2025-06-02 baa72c2 [dev.simd] all: merge master (711ff94) into dev.simd + 2025-05-30 0ff18a9 [dev.simd] cmd/compile: disable intrinsics test for new simd stuff + 2025-05-30 7800f38 [dev.simd] cmd/compile: flip sense of intrinsics test for SIMD + 2025-05-29 eba2430 [dev.simd] simd, cmd/compile, go build, go/doc: test tweaks + 2025-05-29 71c0e55 [dev.simd] cmd/dist: disable API check on dev branch + 2025-05-29 62e1fcc [dev.simd] internal: delete unused internal/simd directory + 2025-05-29 1161228 [dev.simd] cmd/compile: add a fp1m1fp1 register shape to amd64 + 2025-05-28 fdb067d [dev.simd] simd: initialize directory to make it suitable for testing SIMD + 2025-05-28 11d2b28 [dev.simd] cmd/compile: add and fix k register supports + 2025-05-28 04b1030 [dev.simd] cmd/compile: adapters for simd + 2025-05-27 2ef7106 [dev.simd] internal/buildcfg: enable SIMD GOEXPERIMENT for amd64 + 2025-05-22 4d2c71e [dev.simd] internal/goexperiment: add SIMD goexperiment + 2025-05-22 3ac5f2f [dev.simd] codereview.cfg: set up dev.simd branch Change-Id: I60f2cd2ea055384a3788097738c6989630207871
While we're here, document that ID 0 is implicitly assigned to an empty set of data for both stacks and strings. Change-Id: Ic52ff3a1132abc5a8f6f6c4e4357e31e6e7799fc Reviewed-on: https://go-review.googlesource.com/c/go/+/723061 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Knyszek <mknyszek@google.com>
Turns out we spend a few percent of the trace event writing path in just zero-initializing the stack space for pcBuf. We don't need zero initialization, since we're going to write over whatever we actually use. Use m.profStack instead, which is already sized correctly. A side-effect of this change is that trace stacks now obey the GODEBUG profstackdepth where they previously ignored it. The name clearly doesn't match, but this is a positive: there's no reason the maximum stack depth shouldn't apply to every diagnostic. Change-Id: Ia654d3d708f15cbb2e1d95af196ae10b07a65df2 Reviewed-on: https://go-review.googlesource.com/c/go/+/723062 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com> Auto-Submit: Michael Knyszek <mknyszek@google.com>
Turn the experiment back on by default on the dev.simd branch, for the ease of experimenting and development. Change-Id: I5f7e945d55d9d2163e2730b15aea471270599550 Reviewed-on: https://go-review.googlesource.com/c/go/+/723942 Reviewed-by: Junyang Shao <shaojunyang@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Change-Id: Ic113d59144aa2d37c8988559fbc086f5c29c0b69 GitHub-Last-Rev: e2623be GitHub-Pull-Request: #76397 Reviewed-on: https://go-review.googlesource.com/c/go/+/722861 Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Tricky index-offset logic had been added for slices, but not for strings. This fixes that, and also adds tests for same behavior in string/slice cases, and adds a new test for code in prove that had been added but not explicitly tested. Fixes #76270. Change-Id: Ibd92b89e944d86b7f30b4486a9008e6f1ac6af7d Reviewed-on: https://go-review.googlesource.com/c/go/+/723980 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Keith Randall <khr@google.com> Reviewed-by: Keith Randall <khr@golang.org>
This commit integrates ML-DSA ACVP test coverage, describing the capabilities of the crypto/internal/fips140/mldsa package and adding the required command handlers to our ACVP module wrapper. Change-Id: I2aee6f169752a6c6fec3a68591dde33e4f308081 Reviewed-on: https://go-review.googlesource.com/c/go/+/719703 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org> Auto-Submit: Daniel McCarney <daniel@binaryparadox.net> Reviewed-by: Cherry Mui <cherryyz@google.com> Reviewed-by: Filippo Valsorda <filippo@golang.org>
Fixes #56866 Change-Id: Icc8f067820f5d74e0d5073bce160429e6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/723360 Reviewed-by: Daniel McCarney <daniel@binaryparadox.net> Reviewed-by: Cherry Mui <cherryyz@google.com> Auto-Submit: Filippo Valsorda <filippo@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sean Liao <sean@liao.dev> Reviewed-by: Roland Shoemaker <roland@golang.org>
Check to see if a context is canceled at all before checking for the cancellaion cause. If we can't find a cause, use the original error. Avoids a data race where we look for a cause, find none (because the context is not canceled), the context is canceled, and we then return ctx.Err() (even though there is now a cause). Fixes #73390 Change-Id: I97f44aef25c6b02871d987970abfb4c215c5c80e Reviewed-on: https://go-review.googlesource.com/c/go/+/679835 Reviewed-by: Sean Liao <sean@liao.dev> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
Since it uses an Approved KEM (ML-KEM), the overall hybrid KEM is Approved, even if X25519 is not. Updates #70514 Updates #74630 Change-Id: I2bb60c36fcf570baa3c389e2daa3698e6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/728505 Auto-Submit: Filippo Valsorda <filippo@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Consistently use testenv.Command and testenv.Executable, avoid redundant testenv.Must, use testenv.CleanCmdEnv where the output is parsed, always log the output with a preceding newline, invoke tests with -v, and always use cmd.Environ() to preserve existing env. Change-Id: I647ff1a8b7d162e5e8df9424030fac446a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/728641 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: Daniel McCarney <daniel@binaryparadox.net> Auto-Submit: Filippo Valsorda <filippo@golang.org> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
This brings in CL 728480 for fips140only support in x/crypto/chacha20poly1305. This brings in also CL 726280 due to the lockstep x/ dependencies. Updates #70514 Change-Id: I5144a8b260c68c8649fa8d0edb648a0c6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/728501 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Reviewed-by: Roland Shoemaker <roland@golang.org> Auto-Submit: Filippo Valsorda <filippo@golang.org>
This change adds another leaf state to named types which indicates whether the type's size finiteness is known. Without this, writes to Named.finite can result in a clobbered value. While benign in terms of functionality, it triggers the race detector. Fixes #76773 Change-Id: I2ac3d8d6f8be55a8120598daecb3e78aa7df5f30 Reviewed-on: https://go-review.googlesource.com/c/go/+/729021 Reviewed-by: Robert Griesemer <gri@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Mark Freeman <markfreeman@google.com>
When we first implemented DIT (crypto/subtle.WithDataIndependentTiming), we made it so that enabling DIT on a goroutine would lock that goroutine to its current OS thread. This was done to ensure that the DIT state (which is per-thread) would not leak to other goroutines. We also did not make goroutines inherit the DIT state. This change makes goroutines inherit the DIT state from their parent at creation time. It also removes the OS thread locking when enabling DIT on a goroutine. Instead, we now set the DIT state on the OS thread in the scheduler whenever we switch to a goroutine that has DIT enabled, and we unset it when switching to a goroutine that has DIT disabled. We add a new field to G and M, ditEnabled, to track whether the G wants DIT enabled, and whether the M currently has DIT enabled, respectively. When the scheduler executes a goroutine, it checks these fields and enables/disables DIT on the thread as needed. Additionally, cgocallbackg is updated to check if DIT is enabled when being called from C, and sets the G and M fields accordingly. This ensures that if DIT was enabled/disabled in C, the correct state will be reflected in the Go runtime. The behavior as it currently stands is as follows: - The function passed to crypto/subtle.WithDataIndependentTiming will have DIT enabled. - Any goroutine created within that function will inherit DIT enabled for its lifetime. Any goroutine created from subquent goroutines will also inherit DIT enabled for their lifetimes. - Calling into a C function within from a goroutine with DIT enabled will have DIT enabled. - If the C code disables DIT, the goroutine will have DIT re-enabled when returning to Go. - If the C code enables DIT, the goroutine will have DIT disabled when returning to Go if it was not previously enabled. - Calling back into Go code from C will have DIT enabled if it was enabled when calling into C, or if the C code enabled it. Change-Id: I8e91e6df13bb88e56e1036e0e0e5f04efd8eebd3 Reviewed-on: https://go-review.googlesource.com/c/go/+/726382 Reviewed-by: Michael Pratt <mpratt@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
Fixes #76769 Cq-Include-Trybots: luci.golang.try:gotip-linux-amd64-longtest Change-Id: I16b0e9463e2e10ee5a6f20967fb6377b6a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/729180 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Filippo Valsorda <filippo@golang.org> Reviewed-by: Roland Shoemaker <roland@golang.org> Reviewed-by: David Chase <drchase@google.com>
Cherry-pick CL 728560 from the dev.simd branch, for Go 1.26. Change-Id: I9d353769861b35cc808458aa66d243240c235c9f Reviewed-on: https://go-review.googlesource.com/c/go/+/729221 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: David Chase <drchase@google.com> Reviewed-by: David Chase <drchase@google.com>
The ToMask method is for converting an AVX2-style mask represented in a vector to the Mask type. The AVX2-style mask is a (signed) integer, so define ToMask only on integer vectors. Cherry-pick CL 729020 from the dev.simd branch, for Go 1.26. Change-Id: I0c541eb28e945bfaebf2a2feb940bdd438fb6e99 Reviewed-on: https://go-review.googlesource.com/c/go/+/729222 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Auto-Submit: David Chase <drchase@google.com>
To be more consistent with vector.ToMask and mask.ToBits. Cherry-pick CL 729022 from the dev.simd branch, for Go 1.26. Change-Id: I4ea4dfd0059d256f39a93d1fe2ce1de158049800 Reviewed-on: https://go-review.googlesource.com/c/go/+/729223 Auto-Submit: David Chase <drchase@google.com> Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Currently the trace summarization incorrectly handles GoUndetermined by treating it too much like GoNotExist. In particular, it should be accumulating all the time since the start of the trace in a particular bucket, but it doesn't, so that instead gets counted as "unknown time" because the "creation time" is at the start of the trace. This change fixes the problem by simply doing the accumulation. It's very straightforward. It also side-steps some other inaccuracies, like associating a goroutine that is being named with the current task. I don't think this can ever actually happen in practice, but splitting up the two cases, GoUndetermined and GoNotExist, fixes it. Fixes #76716. Change-Id: I3ac1557044f99c92bada2cb0e124b2192b1d6ebb Reviewed-on: https://go-review.googlesource.com/c/go/+/728822 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Carlos Amedee <carlos@golang.org> Reviewed-by: Nick Ripley <nick.ripley@datadoghq.com>
Currently, between the forEachP that ensures every P has a status in the trace and readying dead Ps for the next generation, there's a big window where GOMAXPROCS could run and change the number of Ps. In such circumstances, P state will not get properly prepared for the next generation, and we may fail to emit a status for a P. This change addresses the problem by holding worldsema across both operations. It also moves the status emission and state clearing to before the generation transition because that makes the code *much* clearer. Currently we do both these things after the generation transition targeting the next-next generation. The reason for this is to avoid an extra forEachP (because we already handle P status in the STW for enabling tracing to begin with) but approach is just plain harder to reason about. Preparing the next generation before transitioning to it, like we do for goroutines, is much clearer. Furthermore, we also need to set up the dead P state even if we're stopping the trace, which would mean duplicating code into both branches (if stopping the trace, then we go non-preemptible, otherwise we do it under worldsema) which is also less clear. Note that with this change we no longer need to emit the P statuses during the STW, which was probably the worse choice anyway, since holding up the STW for an O(P) operation is worse than a forEachP we're going to do anyway. So, this change does away with that too. Fixes #76572. Change-Id: Ie7908adff43a8a372cae432bcc2f4e0d6a87d7bc Reviewed-on: https://go-review.googlesource.com/c/go/+/729023 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Michael Pratt <mpratt@google.com>
Commit generated by update.bash. For #22487. Change-Id: If4263150e41253911c99754a6f258722b7dd09d2 Reviewed-on: https://go-review.googlesource.com/c/go/+/729240 Auto-Submit: Dmitri Shuralyov <dmitshur@golang.org> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Historically, Decoder.More reports true when the next read will return an error. Adjust the v2 Decoder to follow this behavior. Fixes #76467 Change-Id: I03bfa391e4e89ada8ca869db43c1d0bb63cc0413 Reviewed-on: https://go-review.googlesource.com/c/go/+/728300 Reviewed-by: Dmitri Shuralyov <dmitshur@google.com> Auto-Submit: Damien Neil <dneil@google.com> Reviewed-by: Joseph Tsai <joetsai@digital-static.net> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
For #75431 Change-Id: Iafefe952d3c1837e2f4c8c24cae96945d9e5abbf Reviewed-on: https://go-review.googlesource.com/c/go/+/728380 Reviewed-by: Joseph Tsai <joetsai@digital-static.net> Auto-Submit: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Add constants for each possible Kind value (KindNull, KindTrue, etc.).
Leave the values unchanged ('n', 't', etc.).
Update documentation to reference the symbols.
Fixes #71756
Change-Id: Ib33b2ad9ee55f6f547d9e6a1c5a7f00c8400d3d3
Reviewed-on: https://go-review.googlesource.com/c/go/+/728420
Auto-Submit: Damien Neil <dneil@google.com>
Reviewed-by: Joseph Tsai <joetsai@digital-static.net>
Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This field is now guarded by a state bit. The "unknown" state is hence indicated by absence of that bit. Change-Id: I9605538f089dd4fd638e5f0f416cd4b8737b6f88 Reviewed-on: https://go-review.googlesource.com/c/go/+/729041 Reviewed-by: Robert Griesemer <gri@google.com> Auto-Submit: Mark Freeman <markfreeman@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Not every OS (e.g. aix) supports ARCH=amd64. Fixes #76792 Change-Id: Id92cd247f1e36574192a6079990c686f9ab55910 Reviewed-on: https://go-review.googlesource.com/c/go/+/729220 Commit-Queue: Alan Donovan <adonovan@google.com> TryBot-Bypass: Alan Donovan <adonovan@google.com> Reviewed-by: Michael Matloob <matloob@google.com> Reviewed-by: Michael Matloob <matloob@golang.org> Auto-Submit: Alan Donovan <adonovan@google.com>
Currently we don't break out of the loop on a failure. This is leading to timeouts trying to parse a broken trace over and over, forever. But there's another issue where when we try to dump the trace, we pass only the unread portion of the bytes.Buffer. Change-Id: I1a338eea08eaf7f592fb7dd2a736a6fe0728c62d Reviewed-on: https://go-review.googlesource.com/c/go/+/729320 Reviewed-by: Carlos Amedee <carlos@golang.org> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
This reverts CL 588435. This new API is difficult to use correctly, and in many cases cannot be used efficiently. We're going to work on this problem a bit more. The release notes are removed by CL 729340, since they were moved to the x/website repository since the original CL was made. Reopens #67546. Change-Id: I2a2bd25f2fce5f02e4d28cd33a9cc651bf35ab50 Reviewed-on: https://go-review.googlesource.com/c/go/+/729360 Reviewed-by: Damien Neil <dneil@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Sean Liao <sean@liao.dev>
Currently TestFinalizerOrCleanupDeadlock runs a bunch of tests for both cleanups and finalizers. However, it doesn't actually distinguish these two cases in the subtest names. This change adds another layer of subtest to distinguish them. For #76523. Change-Id: I18c2857e970cde43c18cbbcbc44e4d4ada3b2628 Reviewed-on: https://go-review.googlesource.com/c/go/+/728821 Reviewed-by: Carlos Amedee <carlos@golang.org> Auto-Submit: Michael Knyszek <mknyszek@google.com> Reviewed-by: Cherry Mui <cherryyz@google.com> TryBot-Bypass: Michael Knyszek <mknyszek@google.com>
The duff device has been dropped on riscv64, we can remove related documentation now. Change-Id: Iffe5093bde6854bca236e290b91ab9f48d3f8c06 Reviewed-on: https://go-review.googlesource.com/c/go/+/728901 Reviewed-by: Mark Ryan <markdryan@rivosinc.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Joel Sing <joel@sing.id.au> Reviewed-by: Dmitri Shuralyov <dmitshur@google.com>
Examples resolved imports based on just the path name, but this doesn't work for go-name or modules on v2+. Updates #12794 Fixes #45110 Fixes #56740 Fixes #62059 Change-Id: I8c71b1e5311df04bccbdf319d759d3176a6a6964 Reviewed-on: https://go-review.googlesource.com/c/go/+/728280 Reviewed-by: Alan Donovan <adonovan@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
So if the goexperiment is not enabled, we don't expose an empty package. Change-Id: I57c1edac92f51b307d789d8d9bb3b505769af589 Reviewed-on: https://go-review.googlesource.com/c/go/+/729361 Reviewed-by: Daniel Morsing <daniel.morsing@gmail.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
Update the blocklist with new linknames added in Go 1.26. Some goroutine leak profile symbols were manually added but they did not match the actual symbol names. Corrected. runtime.freegc is not itself push-linknamed, so there is no need to explicitly add it to blocklist. Keep the test, to ensure one cannot linkname-pull freegc. Change-Id: Ie5fd6bc191e9afa164fa79055cc39e6fa9ed4c7f Reviewed-on: https://go-review.googlesource.com/c/go/+/729720 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
Issue #76540 reports failures in this test from the leaked goroutine count being too small. The test makes an effort to wait for the goroutines to leak, but there's no guarantee. This change instead changes TestGoroutineLeakProfileConcurrency to wait for the number of leaked goroutines to reach at least the minimum expected before proceeding. This deflakes this particular issue. The downside of this change is that a failure to detect leaked goroutines due to a bug will lead to a timeout instead of an instant failure, but this change makes an effort to log and report that it was waiting for the goroutines to leak and timed out for that reason, so at least the failure is more obvious. Overall, this is still better than random flakes. While we're here, I also make some minor stylistic changes and document the helper functions a little more. I also noticed that checkFrames was using the wrong *testing.T, so this change fixes that too. Fixes #76540. Change-Id: I0508855dc39b91f8c6b72d059ce88dbfc68fe748 Reviewed-on: https://go-review.googlesource.com/c/go/+/729280 Reviewed-by: Cherry Mui <cherryyz@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com>
Because we dropg before emitting a trace event in preemptPark, we end up failing to emit a status for the goroutine if this happens to be the first event for it in the generation. We only really see this with multiple subscribers in TestSubscribers. This is for two reasons: 1. If we are missing a status event for a non-initial generation then the trace parser won't validate that (an oversight, but we can only enforce that for new traces because of this bug), and 2. If we're starting the tracer fresh, then we have a STW which effectively guarantees that the first event for a goroutine cannot come from preemptPark. Therefore, we cannot observe this situation unless the first generation manifests the bug, but prior to having flight recording and/or multiple subscribers being able to "cut" the trace data at any point, this was impossible. The fix is simple: dropg only after emitting the trace event. This is also safe, because the tracer doesn't care. The tracer will also start taking a stack trace of the goroutine in this circumstance, but that is also safe, since we are able to generally unwind the stack of asynchronously preempted goroutines, and here we're at the very, very end of asynchronous preemption where all the state to do so is already set up. Fixes #75665. Change-Id: I7ee1142697d0a53b62d4c5647aa53775d2f6976a Reviewed-on: https://go-review.googlesource.com/c/go/+/729400 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: Cherry Mui <cherryyz@google.com>
During review of CL 704615, a suggestion was made that spawning a goroutine inside a call to secret.Do result in a panic. I agreed with this at the time, but had missed that this had been extensively discussed on the proposal. Revert the behavior back to what was agreed upon. Change-Id: Ifaa9e24bd03ecbd870ae2217137d1a9527c96842 Reviewed-on: https://go-review.googlesource.com/c/go/+/728920 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com> Reviewed-by: Roland Shoemaker <roland@golang.org>
A stackObjectRecord should always be in funcdata, between gofunc and the end of pclntab, except for the special case of methodValueCallFrameObjs, which should always be in noptrbss. Adjust the two loops that look for the moduledata corresponding to a stackObjectRecord to search more precisely, rather than relying on datap.end. Closely based on a patch by Michael Stapelberg. For #76038 Change-Id: I751801d8fd030af751825a67905b2a343280e7d9 Reviewed-on: https://go-review.googlesource.com/c/go/+/728840 Reviewed-by: David Chase <drchase@google.com> LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Auto-Submit: Ian Lance Taylor <iant@golang.org> Reviewed-by: Cherry Mui <cherryyz@google.com>
Change-Id: Iaf8bb811cd8c674c801d8e068fcc753e889ac672 Reviewed-on: https://go-review.googlesource.com/c/go/+/729721 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
The simd operations require AVX. If AVX is not available, skip the tests. Change-Id: I3c384ba07e1e6c2c198dfb27bc84a2e27f825680 Reviewed-on: https://go-review.googlesource.com/c/go/+/729820 LUCI-TryBot-Result: Go LUCI <golang-scoped@luci-project-accounts.iam.gserviceaccount.com> Reviewed-by: David Chase <drchase@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot]
Can you help keep this open source service alive? 💖 Please sponsor : )