Editor: Show actual class name in resource picker tooltips

[MattiaZir]

• Replaced generic "Resource" with the actual class name (e.g. "Texture2D").
• Used TTRN for correct pluralization support.
• Removed unnecessary parentheses around the count.

This fixes #113310

[KoBeWi]

Could the first string be empty or something? There resource will never be used in only one place.

[MattiaZir]

I thought about it but it might be better to leave it instead.
An empty string might break the template generation since "" is reserved for the PO file metadata in gettext if I remember correctly.

Worst case scenario, the first string never gets used.

What do you think?

[KoBeWi]

That's more a question to @timothyqiu

[timothyqiu]

resource_name is used to format strings for translation and is not translated itself. So whether it is empty has nothing to do with TTRN / PO. I believe you need to consider the possibility of it being empty because if it is empty, the resulting formatted string might look strange.

[MattiaZir]

So if I understand correctly the first string ("This %s is used in %d place.") can be empty as @KoBeWi suggested?

Or do you mean that we should make sure that the variable resource is never empty since it could mess up the formatted string?

[timothyqiu]

Oh, I thought you were referring to the first placeholder.

In addition to technical requirements, the arguments of TTRN will be provided to translators as a reference. Therefore, they should not be left blank.

[MattiaZir]

Thank you

[KoBeWi]

What happened to unique_enable?
It should be something like

Suggested change

	tooltip += "\n" + TTR("Left-click to make it unique.") + "\n";
	if (unique_enable) {
	tooltip += "\n" + TTR("Left-click to make it unique.") + "\n";
	}

[MattiaZir]

Nice catch, I misread the logic there and removed the unique_enable by mistake.

[KoBeWi]

Seems like get_custom_type_script() does not check if the object has relevant meta value.

You need to add has_meta(SceneStringName(_custom_type_script)) check.

[MattiaZir]

Closing this to clean up the commit history, sorry.

Superseded by #113828