Deallocate m_mem only if not nullptr#13
Merged
gmarcais merged 1 commit intogmarcais:developfrom Jan 27, 2025
Merged
Conversation
Owner
|
The difference between |
mweisgut
added a commit
to hyrise/hyrise
that referenced
this pull request
May 3, 2025
This PR - replaces `boost::container::pmr` classes with `std::pmr` as both Clang and GCC support it. - pushes the minimum supported GCC version from 11 to 13.2 as GCC supports `std::pmr` in version >= 13.2. - Updates `compact_vector` to v0.1.3 as it [tried to deallocate memory](https://github.com/gmarcais/compact_vector/blob/9d5b66a4564582911780a9485765f61c74b95a4c/include/compact_vector.hpp#L98) for a given [nulltpr after using the move constructor](https://github.com/gmarcais/compact_vector/blob/9d5b66a4564582911780a9485765f61c74b95a4c/include/compact_vector.hpp#L74). This is [undefined behavior when called on a memory resource](https://en.cppreference.com/w/cpp/memory/memory_resource/deallocate). Related to gmarcais/compact_vector#13 ---------
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The deconstructor tries to deallocate memory for a given nulltpr if the move constructor has been used before. If the allocator is an
std::pmr::polymorphic_allocator, the memory resource'sdeallocatefunction will be called with a nullptr. This is undefined behavior.This PR adds a simple check so that the deconstructor only deallocates
m_memif it is notnullptr.