Skip to content

fix(python): add timeout parameter to FleetApi.start() #548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
haosenwang1018 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(python): add timeout parameter to FleetApi.start() #548

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 15 additions & 2 deletions python/copilot/generated/rpc.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1015,10 +1015,23 @@ def __init__(self, client: "JsonRpcClient", session_id: str):
self._client = client
self._session_id = session_id

async def start(self, params: SessionFleetStartParams) -> SessionFleetStartResult:
async def start(
self, params: SessionFleetStartParams, *, timeout: float = 600.0
) -> SessionFleetStartResult:
"""Start a fleet.

Args:
params: Fleet start parameters.
timeout: Request timeout in seconds. Defaults to 600s (10 min)
because fleet.start blocks until the fleet completes and
the session goes idle, which routinely exceeds the default
30s JSON-RPC timeout.
"""
params_dict = {k: v for k, v in params.to_dict().items() if v is not None}
params_dict["sessionId"] = self._session_id
return SessionFleetStartResult.from_dict(await self._client.request("session.fleet.start", params_dict))
return SessionFleetStartResult.from_dict(
await self._client.request("session.fleet.start", params_dict, timeout=timeout)
)


class SessionRpc:
Expand Down