E_ITP metric #1
Open
E_ITP metric #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mantiuk
requested changes
Jan 4, 2023
Collaborator
mantiuk
left a comment
mantiuk
left a comment
There was a problem hiding this comment.
We have updated video_source classes since you wrote that class, and now there is now a better way to implement a conversion to ITP. Please see the comments below.
pycvvdp/video_source.py
Outdated
| LMS = frame*self.color_to_L[0] + frame*self.color_to_L[1] + frame*self.color_to_L[2] | ||
|
|
||
| # Apply PQ curve | ||
| LMS_p = self.dm_photometry.forward( LMS ) |
Collaborator
There was a problem hiding this comment.
The display model must be applied in the RGB colour space (of the display). Not LMS.
|
How is the ∆E-ITP metric used in cvvdp? |
Collaborator
|
It is not used. It was a separate sub-project and we use it as one of the reference metrics for the benchmarks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added e_itp file similar to pu_psnr
Added RGB to ITP subclasses in video_source class