-
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(trace-tree-node): Mitigating error node type guards usage #104501
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Abdkhan14
merged 4 commits into
abdk/trace-tree-node-uptime-check-guard-usage
from
abdk/trace-tree-node-error-guards-usage
Dec 12, 2025
+923
−446
Merged
Changes from all commits
Commits
Show all changes
4 commits
Select commit
Hold shift + click to select a range
e3c5a59
feat(trace-tree-node): Mitigating error node type guards usage
a2bd2e0
Merge branch 'abdk/trace-tree-node-uptime-check-guard-usage' into abd…
e9c2697
feat(trace-tree-node): Fixing small bug
10b8670
feat(trace-tree-node): Mitigating trace root node type guards usage (…
Abdkhan14 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74 changes: 74 additions & 0 deletions
74
static/app/views/performance/newTraceDetails/traceDrawer/details/autogroup/index.spec.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,74 @@ | ||
| import {OrganizationFixture} from 'sentry-fixture/organization'; | ||
|
|
||
| import {render, screen} from 'sentry-test/reactTestingLibrary'; | ||
|
|
||
| import type {TraceTreeNodeExtra} from 'sentry/views/performance/newTraceDetails/traceModels/traceTreeNode/baseNode'; | ||
| import {EapSpanNode} from 'sentry/views/performance/newTraceDetails/traceModels/traceTreeNode/eapSpanNode'; | ||
| import {SiblingAutogroupNode} from 'sentry/views/performance/newTraceDetails/traceModels/traceTreeNode/siblingAutogroupNode'; | ||
| import { | ||
| makeEAPSpan, | ||
| makeSiblingAutogroup, | ||
| } from 'sentry/views/performance/newTraceDetails/traceModels/traceTreeTestUtils'; | ||
| import {DEFAULT_TRACE_VIEW_PREFERENCES} from 'sentry/views/performance/newTraceDetails/traceState/tracePreferences'; | ||
| import {TraceStateProvider} from 'sentry/views/performance/newTraceDetails/traceState/traceStateProvider'; | ||
|
|
||
| import {AutogroupNodeDetails} from './index'; | ||
|
|
||
| const createMockExtra = ( | ||
| overrides: Partial<TraceTreeNodeExtra> = {} | ||
| ): TraceTreeNodeExtra => ({ | ||
| organization: OrganizationFixture(), | ||
| ...overrides, | ||
| }); | ||
|
|
||
| describe('AutogroupNodeDetails', () => { | ||
| it('renders autogroup details with title and description', () => { | ||
| const organization = OrganizationFixture(); | ||
| const extra = createMockExtra({organization}); | ||
| const autogroupValue = makeSiblingAutogroup({ | ||
| span_id: 'test-span-id', | ||
| autogrouped_by: { | ||
| op: 'db.query', | ||
| description: 'SELECT * FROM users', | ||
| }, | ||
| }); | ||
|
|
||
| const childSpanValue = makeEAPSpan({event_id: 'child-span-1'}); | ||
| const childNode = new EapSpanNode(null, childSpanValue, extra); | ||
| const node = new SiblingAutogroupNode(null, autogroupValue, extra); | ||
| node.children = [childNode]; | ||
|
|
||
| render( | ||
| <TraceStateProvider initialPreferences={DEFAULT_TRACE_VIEW_PREFERENCES}> | ||
| <AutogroupNodeDetails | ||
| node={node as any} | ||
| organization={organization} | ||
| onTabScrollToNode={jest.fn()} | ||
| onParentClick={jest.fn()} | ||
| manager={null} | ||
| replay={null} | ||
| traceId="test-trace-id" | ||
| /> | ||
| </TraceStateProvider> | ||
| ); | ||
|
|
||
| expect(screen.getByText('Autogroup')).toBeInTheDocument(); | ||
|
|
||
| expect(screen.getByText(/ID: test-span-id/)).toBeInTheDocument(); | ||
|
|
||
| expect( | ||
| screen.getByText(/This block represents autogrouped spans/) | ||
| ).toBeInTheDocument(); | ||
|
|
||
| expect( | ||
| screen.getByText('5 or more siblings with the same operation and description') | ||
| ).toBeInTheDocument(); | ||
| expect( | ||
| screen.getByText('2 or more descendants with the same operation') | ||
| ).toBeInTheDocument(); | ||
|
|
||
| expect( | ||
| screen.getByText(/You can either open this autogroup using the chevron/) | ||
| ).toBeInTheDocument(); | ||
| }); | ||
| }); |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug: Wrong property checked in
eventIdconditionThe condition for extracting
eventIdchecks forOurLogKnownFieldKey.PROJECT_IDin the event, but then accessesOurLogKnownFieldKey.ID. The original code checkedOurLogKnownFieldKey.ID in rep.eventbefore accessing the ID field. While this works in practice because logs always contain both fields, it's checking the wrong property and could fail if the data contract changes. The condition should check for the property that's actually being accessed.