ref(profile-chunks): Finally forbid profile chunk items without platform header #5507
+36
−78
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dav1dde
force-pushed
the
dav1d/forbid-profile-chunk-no-platform
branch
from
8300789 to
d7227e3
Compare
Dav1dde
force-pushed
the
dav1d/forbid-profile-chunk-no-platform
branch
from
d7227e3 to
e228d32
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This has been long in the making, see also #4595 for historic context.
Profile chunks without a platform header in the item header are considered invalid, we simply accepted them at the point of introduction to give some compatibility with beta SDKs.