Skip to content

Conversation

@Dav1dde
Copy link
Member

@Dav1dde Dav1dde commented Oct 24, 2025

One step closer to replacing ManagedEnvelope with Managed<Envelope>.

This is also a first step into improving our outcome handling in endpoints (#5288) by providing a more explicit error handling. It remains to be seen how far we can use Rejected for these purposes though.

Active rate limit handling has been made a bit more explicit, it was already handled in a few different ways in endpoints, this is an attempt to make it a bit more explicit. It is necessary because we require common::handle_envelope to return Rejected<E>, which makes the active rate limits explicitly returned on success. Callers then have to decide what to do.

We may want to revisit the rate limiting behaviour of endpoints in the future again.

This also fixes some errors that came up with handling of outcomes when migrating to the more strict Managed type, like UserReport outcomes not being emitted in Managed::reject.

@Dav1dde Dav1dde force-pushed the dav1d/managed-envelope-endpoint branch 3 times, most recently from b5da373 to 4f9f4a4 Compare October 24, 2025 12:47
@Dav1dde Dav1dde self-assigned this Oct 24, 2025
@Dav1dde Dav1dde force-pushed the dav1d/managed-envelope-endpoint branch from 4f9f4a4 to 67273ff Compare December 22, 2025 10:51
@Dav1dde Dav1dde marked this pull request as ready for review December 22, 2025 10:52
@Dav1dde Dav1dde requested a review from a team as a code owner December 22, 2025 10:52
@Dav1dde Dav1dde force-pushed the dav1d/managed-envelope-endpoint branch from 67273ff to a24f077 Compare December 22, 2025 11:48
@Dav1dde Dav1dde force-pushed the dav1d/managed-envelope-endpoint branch from a24f077 to 0cb9e84 Compare December 22, 2025 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants