fix: source bootstrap.sh in docker-authn.sh before calling devbase_configure_global_tools#1089
Closed
fix: source bootstrap.sh in docker-authn.sh before calling devbase_configure_global_tools#1089
Conversation
…nfigure_global_tools devbase_configure_global_tools calls get_devbase_directory, which is defined in bootstrap.sh. Without sourcing bootstrap.sh first, get_devbase_directory is undefined, causing mise.devbase.toml to not be copied and ghaccesstoken to have no version set, breaking GitHub auth in CI docker/release jobs.
Member
|
There's more than this to fix it, I'm working on a PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please read CONTRIBUTING.md for additional information on contributing to this repository!
What this PR does / why we need it
Without sourcing bootstrap.sh first, get_devbase_directory is undefined, causing mise.devbase.toml to not be copied and ghaccesstoken to have no version set.
Jira ID
[XX-XX]
Notes for your reviewers
Rovo Dev code review: Rovo Dev has reviewed this pull request
Any suggestions or improvements have been posted as pull request comments.