Merged
Conversation
* chore: update mise.lock
--------- Co-authored-by: Mark Lee <mark.lee@outreach.io>
…15.17 (#1023) chore(deps): bump github.com/getoutreach/localizer Bumps [github.com/getoutreach/localizer](https://github.com/getoutreach/localizer) from 1.15.16 to 1.15.17. - [Release notes](https://github.com/getoutreach/localizer/releases) - [Changelog](https://github.com/getoutreach/localizer/blob/main/.releaserc.yaml) - [Commits](getoutreach/localizer@v1.15.16...v1.15.17) --- updated-dependencies: - dependency-name: github.com/getoutreach/localizer dependency-version: 1.15.17 dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
--------- Co-authored-by: Mark Lee <malept@users.noreply.github.com> Co-authored-by: Mark Lee <mark.lee@outreach.io>
* refactor(golangci-lint): use mise instead of asdf to run * refactor: move cache var out of Makefile and into wrapper script --------- Co-authored-by: Mark Lee <mark.lee@outreach.io> Co-authored-by: Mark Lee <malept@users.noreply.github.com>
* chore: add helper to make mise-based stubs * chore(lintroller): upgrade to 1.18.11 * fix(mise): ensure GitHub token is used when installing tool * fix(mise): only look for wait-for-gh-rate-limit on CI * chore: allow custom lintroller script (mostly for lintroller itself)
--------- Co-authored-by: Egor Kalinichev <egor.kalinichev@outreach.io> Co-authored-by: Mark Lee <malept@users.noreply.github.com> Co-authored-by: Mark Lee <mark.lee@outreach.io>
* chore: sync mise.lock with devbase env --------- Co-authored-by: getoutreach-ci-1[bot] <95656460+getoutreach-ci-1[bot]@users.noreply.github.com> Co-authored-by: Mark Lee <mark.lee@outreach.io>
* feat(lint): add TOML linters/formatters * Better lock info for tombi
* chore: update mise.lock * fix(mise): enable lockfile support * fix: validate mise lockfile when installing tools * Remove duplicate entry * refactor: define and run delibird via mise config * chore: add post-stencil task to upgrade devbase tools * Add mise and Stencil lockfiles to .gitattributes --------- Co-authored-by: Egor Kalinichev <egor.kalinichev@outreach.io>
* build(deps): upgrade github.com/go-git/go-git/v5 from v5.16.2 to v5.16.5 --------- Co-authored-by: getoutreach-ci-1[bot] <95656460+getoutreach-ci-1[bot]@users.noreply.github.com> Co-authored-by: Mark Lee <mark.lee@outreach.io>
* fix(mise): reshim asdf tools after executing in non-CI * Make sure asdf reshim output goes to stderr
* fix(golangci-lint): Go >= 1.26 needs golangci-lint >= 2.9.0 * fix(golangci-lint): only append arguments if they work for the given subcommand * fix(golangci-lint): better error message when config version doesn't match tool version (#1081)
* refactor: define and run delibird via mise config * refactor: migrate terraform to mise * refactor: migrate goreleaser to mise
Bumps [google.golang.org/grpc](https://github.com/grpc/grpc-go) from 1.78.0 to 1.79.0. - [Release notes](https://github.com/grpc/grpc-go/releases) - [Commits](grpc/grpc-go@v1.78.0...v1.79.0) --- updated-dependencies: - dependency-name: google.golang.org/grpc dependency-version: 1.79.0 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Contributor
|
Link to code coverage report (posted by coverbot 🤖) |
ekalinichev
approved these changes
Feb 19, 2026
![atlassian[bot]](https://avatars.githubusercontent.com/in/14320?s=60&v=4){kind=small}
| if [[ -n ${CIRCLECI_ORB_SYNC_FILES:-} ]]; then | ||
| readarray -t -d ' ' extraFiles < <(echo "$CIRCLECI_ORB_SYNC_FILES") | ||
| configFiles+=("${extraFiles[@]}") | ||
| for extraFile in $CIRCLECI_ORB_SYNC_FILES; do |
Contributor
There was a problem hiding this comment.
🔥 Code Bugs
Quote $CIRCLECI_ORB_SYNC_FILES in the for loop to prevent word splitting issues with file paths containing spaces.
Details
📖 Explanation: The unquoted variable will undergo word splitting, which could cause issues if file paths contain spaces. While the old code used space as a delimiter intentionally, the current implementation should either quote the variable with proper IFS handling or document that spaces in paths are not supported.
Suggested change
| for extraFile in $CIRCLECI_ORB_SYNC_FILES; do | |
| for extraFile in "$CIRCLECI_ORB_SYNC_FILES"; do |
Contributor
|
🎉 This PR is included in version 2.35.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge tmp-release-stable-v2.35.0-rc.24 to release
Rovo Dev code review: Rovo Dev has reviewed this pull request
Any suggestions or improvements have been posted as pull request comments.