feat(sails-rs): Introduce sails clients for gear builtins #1005
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techraed
commented
Jul 23, 2025
| }; | ||
| use gbuiltin_proxy::{ProxyType as GearProxyType, Request as GearProxyRequest}; | ||
|
|
||
| // todo [sab] make typeinfo types on gear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #976
The testing approach should be mentioned. There was an idea to test clients using real node. The problem of this approach is that it's pretty hard to distinguish between testing integration (the client impl itself) and builtin business logic, because builtins must be called properly. As a compromise, builtins could be called with wrong inputs.
That's why codec tests were agreed to be implemented: test no routes are defined in encoded/decoded action data.