refactor(ethexe-service): Event handling in tests

[ark0f]

No description provided.

[semanticdiff-com]

Review changes with  

Changed Files

File	Status
ethexe/service/src/tests/mod.rs	36% smaller
ethexe/service/src/tests/utils/env.rs	35% smaller
ethexe/service/src/tests/utils/events.rs	17% smaller
Cargo.lock	Unsupported file format
Cargo.toml	Unsupported file format
ethexe/service/Cargo.toml	Unsupported file format
ethexe/service/src/fast_sync.rs	Unsupported file format
ethexe/service/src/lib.rs	Unsupported file format
utils/gear-workspace-hack/Cargo.toml	Unsupported file format

[gemini-code-assist]

Summary of Changes

Hello @ark0f, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the reliability and readability of the ethexe-service test suite by overhauling its event handling infrastructure. The core change involves migrating from a custom event listener implementation to a more robust and idiomatic asynchronous event broadcasting system utilizing the async-broadcast crate and futures::StreamExt utilities. This refactoring simplifies how tests wait for and process events, reducing boilerplate and improving maintainability.

Highlights

• Event Handling Refactor: The event handling mechanism within the test suite has been significantly refactored, moving from custom tokio::sync::broadcast based listeners to a more streamlined approach using the async-broadcast crate and futures::StreamExt combinators.
• Simplified Test Code: Test code that previously used apply_until and wait_for methods with ControlFlow has been updated to use standard asynchronous stream methods like find and find_map, making the test logic more concise and idiomatic.
• New Dependency: The async-broadcast crate, version 0.7.2, has been introduced as a new dependency to facilitate the updated event broadcasting in tests.
• Test Timeout Adjustment: The timeout for the execution_with_canonical_events_quarantine test has been increased from 50 seconds to 60 seconds, likely to accommodate potential variations in execution time with the new event handling.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request is a great refactoring of the event handling logic in tests. It replaces the manual and verbose ControlFlow based event waiting with a much cleaner and more idiomatic stream-based approach using async-broadcast and StreamExt combinators. This significantly improves readability and maintainability of the tests. I've found one critical issue in the new Stream implementation for EventReceiver that needs to be addressed.