Skip to content

Conversation

@reiniscirpons
Copy link
Contributor

This PR removes or adds brackets to certain barcodes to make the resulting gap files syntactically valid. In particular the derived series for n=4 is has an extra bracket which renders it invalid as gap code. For n=83 all of the barcodes are empty, which seems wrong. I tried fixing it by adding extra brackets to make the files valid gap code, but it might be better to remove the files altogether, unless there is a mathematical reason why there should not be any barcodes for n=83 (I don't have enough understanding of the mathematics to know).

@grahamknockillaree grahamknockillaree merged commit e2c42b5 into gap-packages:master Jan 26, 2026
5 of 6 checks passed
@grahamknockillaree
Copy link
Collaborator

Thanks for spotting this.

I'll add data for n=83 soon. Actually, I think the files for prime n are all the same, so I should not really be including a separate file for each prime. I'll look into this.

@codecov
Copy link

codecov bot commented Jan 26, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.74%. Comparing base (958f3e6) to head (6c3f73a).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #145   +/-   ##
=======================================
  Coverage   44.74%   44.74%           
=======================================
  Files         349      349           
  Lines       64422    64422           
=======================================
  Hits        28825    28825           
  Misses      35597    35597           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants