Remove hack which builds the IO package #62
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was/is a workaround for issues in RepnDecomp and HeLP and maybe other packages that went undetected so far.
Contributor
|
I've made an issue asking the developers/maintainers of RepnDecomp to kindly make a release 🙂 |
wilfwilson
approved these changes
Sep 15, 2025
Contributor
wilfwilson
left a comment
wilfwilson
left a comment
There was a problem hiding this comment.
I don't think we actually have to wait for HeLP to get fixed; the issue with HeLP only appeared when we introduced this hack, I believe.
Of course, the issue with HeLP still exists, but I don't think it will affect our CI in gap-actions/run-pkg-tests#45 if this PR is merged.
Contributor
|
HeLP just got a new release that is supposed to fix the problems, I think. |
fingolfin
added a commit
that referenced
this pull request
Jan 13, 2026
This reverts commit 1a2238b. Too many packages still need IO implicitly or explicitly in their tests, and until gap-actions/install-pkg or some other solution is ready, they have no good way of getting IO built.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was/is a workaround for issues in RepnDecomp and HeLP and maybe other packages that went undetected so far.
Should not be merged until fixes for those issues are in releases of those packages: