Skip to content

Conversation

@wilfwilson
Copy link
Contributor

Resolves #36.

@wilfwilson
Copy link
Contributor Author

I just another test release of the Semigroups package on my fork, v7.8.11 from the fake-release branch, at https://github.com/wilfwilson/Semigroups/releases/tag/v7.8.11

I can confirm that the tag was made against the correct commit, so I believe that this PR is correct and ready to be merged.

Copy link
Contributor

@stertooy stertooy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Out of curiosity: is there any difference between using github.sha versus github.ref_name ?

@wilfwilson
Copy link
Contributor Author

wilfwilson commented Sep 11, 2025

From the documentation:

The short ref name of the branch or tag that triggered the workflow run. This value matches the branch or tag name shown on GitHub. For example, feature-branch-1.

For pull requests, the format is <pr_number>/merge.

So for some workflow runs, such as for a job triggered by workflow_dispatch (which includes most/all package releases), I think the value might be empty.

On the other hand, I think github.sha should always have a value, and it seems more 'precise' anyway, so I went for that one 🙂

@wilfwilson wilfwilson merged commit e30d72e into main Sep 11, 2025
3 checks passed
@wilfwilson wilfwilson deleted the ww/fix-issue-36 branch September 11, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

This action can tag the wrong commit when making a release

3 participants