-
Notifications
You must be signed in to change notification settings - Fork 168
Add Catalog of games #735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add Catalog of games #735
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
…ut needing to instantiate the full game object
… circular imports issue
…to avoid circular imports issue" This reverts commit 4d46dd5.
…est that attempting to subclass CatalogGame without a _game func raises an error
|
@tturocy @rahulsavani This is now ready for review - there's a lot happening in this PR, so please take a look at the docs links I've added in the top comment of this PR which should explain how everything now works. I'm going to create some additional feature issues for the catalog and add them to the list in #394 After your review, we can make a bunch of PRs to update the catalog entries for these purposes:
We should decide whether we want to merge this branch into master now and make those PRs there, or alternatively you could branch off |
Issues closed by this PR
Description of the changes in this PR
This PR adds infrastructure and documentation for an a first version of the Catalog of games:
contrib/gamestosrc/pygambit/catalog_game_filessrc/pygambit/catalog_games.pyor from file insrc/pygambit/catalog.ymlsrc/pygambit/catalog_update.py(usage described in developer docs)How to review this PR