Skip to content

Number input now works #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
K-E-L wants to merge 1 commit into
base: nightly
Choose a base branch
from
Open

Number input now works #406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions public/js/chunks/4843.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion public/js/gravity.js
View file
Open in desktop

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion public/mix-manifest.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"/js/gravity.js": "/js/gravity.js?id=190ae9a58e8b2b35a42f",
"/js/gravity.js": "/js/gravity.js?id=2be4c35fc78f449dc93e",
"/css/gravity.css": "/css/gravity.css?id=f4312103778cfc5c63f0",
"/img/audio-large.svg": "/img/audio-large.svg?id=fca6a67c7ef06d00ef4a",
"/img/audio-small.svg": "/img/audio-small.svg?id=48f5a5c5ff1cfd2cb375",
Expand Down
6 changes: 3 additions & 3 deletions resources/js/components/Fieldtypes/Number/Field.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,10 @@
:help="field.help"
:value="value"
:placeholder="field.settings.placeholder"
:step="field.settings.step"
:step="Number(field.settings.options.find(option => option.value === 'step').label)"
:decimals="field.settings.decimals"
:min="Number(field.settings.min)"
:max="Number(field.settings.max)"
:min="Number(field.settings.options.find(option => option.value === 'min').label)"
:max="Number(field.settings.options.find(option => option.value === 'max').label)"
:has-error="hasError(field.handle)"
:error-message="errorMessage(field.handle)"
@input="$emit('input', Number($event))">
Expand Down
8 changes: 2 additions & 6 deletions settings/api.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,13 +21,9 @@
'handle' => 'rate_limit',
'description' => 'Set default request limit for users within a minute.',
'type' => 'number',
'options' => [
'min' => 20,
'max' => 120,
'step' => 10,
],
'options' => [ 'min' => 20, 'max' => 120, 'step' => 10 ],
'default' => '60',
'required' => false,
'required' => true,
],
],
],
Expand Down
10 changes: 10 additions & 0 deletions settings/backups.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,40 +34,50 @@
'handle' => 'keep_all_backups_for_days',
'description' => 'The number of days for which backups must be kept.',
'type' => 'number',
'options' => [ 'min' => 0, 'max' => 365, 'step' => 1 ],
'default' => 7,
'override' => 'backup.cleanup.default_strategy.keep_all_backups_for_days',
'required' => true,
],
[
'name' => 'Keep Daily Backups For Days',
'handle' => 'keep_daily_backups_for_days',
'description' => 'The number of days for which daily backups must be kept.',
'type' => 'number',
'options' => [ 'min' => 0, 'max' => 365, 'step' => 1 ],
'default' => 16,
'override' => 'backup.cleanup.default_strategy.keep_daily_backups_for_days',
'required' => true,
],
[
'name' => 'Keep Weekly Backups For Weeks',
'handle' => 'keep_weekly_backups_for_weeks',
'description' => 'The number of weeks for which one weekly backup must be kept.',
'type' => 'number',
'options' => [ 'min' => 0, 'max' => 365, 'step' => 1 ],
'default' => 8,
'override' => 'backup.cleanup.default_strategy.keep_weekly_backups_for_weeks',
'required' => true,
],
[
'name' => 'Keep Monthly Backups For Months',
'handle' => 'keep_monthly_backups_for_months',
'description' => 'The number of months for which one monthly backup must be kept.',
'type' => 'number',
'options' => [ 'min' => 0, 'max' => 365, 'step' => 1 ],
'default' => 4,
'override' => 'backup.cleanup.default_strategy.keep_monthly_backups_for_months',
'required' => true,
],
[
'name' => 'Keep Yearly Backups For Years',
'handle' => 'keep_yearly_backups_for_years',
'description' => 'The number of years for which one yearly backup must be kept.',
'type' => 'number',
'options' => [ 'min' => 0, 'max' => 365, 'step' => 1 ],
'default' => 2,
'override' => 'backup.cleanup.default_strategy.keep_yearly_backups_for_years',
'required' => true,
],
],
],
Expand Down
2 changes: 1 addition & 1 deletion settings/cors.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
'options' => [
'min' => 0,
'max' => 120,
'step' => 'any',
'step' => 1,
],
'default' => 0,
'override' => 'cors.max_age',
Expand Down
2 changes: 1 addition & 1 deletion settings/files.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
'options' => [
'min' => 0,
'max' => 50,
'step' => 'any',
'step' => 1,
],
'default' => 15,
'required' => true,
Expand Down