Mananmukim/sc 146920/verify api client library changes #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been linked to Shortcut Story #146920: Verify API Client Library Changes. |
gilbertdev
approved these changes
Oct 24, 2022
gilbertdev
left a comment
gilbertdev
left a comment
There was a problem hiding this comment.
Everything seems to work and match bouncer code changes.
| Double emails; | ||
| Double online; | ||
| Double social; | ||
| Double employment; |
There was a problem hiding this comment.
This all matches bouncer class ActivityResponse, except bouncer has added a new field "message."
| private String givenName; | ||
| private String phone; | ||
| private String email; | ||
| private Double risk; |
There was a problem hiding this comment.
This all matches bouncer's MatchResponse, though bouncer has several more fields available now.
| Assert.assertEquals("household", response.getFamilyName()); | ||
| Assert.assertEquals("household", response.getPostalCode()); | ||
| Assert.assertEquals("household", response.getCountry()); | ||
| Assert.assertEquals("household", response.getCity()); |
| Assert.assertEquals("0.32", String.valueOf(response.getSocial())); | ||
| Assert.assertEquals("0.78", String.valueOf(response.getEmployment())); | ||
| Assert.assertEquals("0.91", String.valueOf(response.getOnline())); | ||
| } |
| "emails" : 0.82, | ||
| "online" : 0.91, | ||
| "social" : 0.32, | ||
| "employment" : 0.78 |
There was a problem hiding this comment.
This is mocked for test to pass. I do wonder if we should have a test for this library with live api calls in the future.
| "familyName": "household", | ||
| "phone" : "tangled", | ||
| "email" : "self", | ||
| "risk" : 0.21 |
| "emails" : 0.82, | ||
| "online" : 0.91, | ||
| "social" : 0.32, | ||
| "employment" : 0.78 |
| "familyName": "household", | ||
| "phone" : "tangled", | ||
| "email" : "self", | ||
| "risk" : 0.21 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Verify Response Updates