Skip to content

Conversation

@freezy
Copy link
Owner

@freezy freezy commented Aug 21, 2025

Fixes compilation errors on latest Unity version, as well as the emission intensity issue.

@freezy freezy requested a review from Copilot August 21, 2025 09:07
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors the segment display shader to improve maintainability by replacing global shader parameters with a structured context approach. The key change is eliminating global variables and parameter passing in favor of a centralized SegContext structure that encapsulates all segment display parameters.

  • Introduces a SegContext struct to encapsulate all segment display parameters
  • Removes global shader variables and replaces them with context-based parameter passing
  • Updates all segment display functions to accept and use the context structure

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File Description
SegmentDisplayShader.hlsl Main shader refactoring: removes global variables, adds SegContext struct, updates all functions to use context parameters
SegmentDisplayGraph.shadergraph Updates shader graph configuration to support the new context-based approach and removes deprecated HDRP emission node

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@freezy freezy merged commit 34668fa into master Aug 21, 2025
15 checks passed
@freezy freezy deleted the fix/segshader branch August 21, 2025 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants