-
Notifications
You must be signed in to change notification settings - Fork 71
Latest updates #546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest updates #546
Conversation
…al version is selected and visible.
…n. Also, actually make use of gate collission min height.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This is a comprehensive update spanning several months covering animation system changes, material updates, asset browser improvements, and various bug fixes. The main purpose is to modernize the animation system using a publisher-subscriber pattern and update materials for HDRP 17 compatibility.
- New pub/sub-based animation system replacing direct component references
- Asset browser enhancements with improved material variations support
- Physics improvements and collision detection fixes
Reviewed Changes
Copilot reviewed 151 out of 152 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| AnimationComponent.cs | Complete rewrite to use generic pub/sub pattern |
| IAnimationValueEmitter.cs | New interface for animation value emission |
| PhysicsEngine.cs | Updated to use new animation system dictionaries |
| Multiple component files | Implement IAnimationValueEmitter interface |
| Asset browser files | Enhanced material variations and UI improvements |
| Physics collision files | Bug fixes for collision detection |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
VisualPinball.Unity/VisualPinball.Unity/VPT/Gate/GateDisplacementPhysics.cs
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
These are my changes from the last months. Will try to be more disciplined to better separate PRs.
Changes: