Skip to content

Fix SQLite adapter with GroupedRecords#216

Open
yunzheng wants to merge 1 commit intomainfrom
bugfix/sqlite-grouped-record
Open

Fix SQLite adapter with GroupedRecords#216
yunzheng wants to merge 1 commit intomainfrom
bugfix/sqlite-grouped-record

Conversation

@yunzheng
Copy link
Member

@yunzheng yunzheng commented Feb 23, 2026

This PR ensures that we don't use record.__slots__ but rather rdict.keys() for creating the sqlite table. Small regression test is included.

Also fixes some other small issues I encountered with GroupedRecord class, mainly by renaming the class variables to dunder variables.

fixes #215

@codecov
Copy link

codecov bot commented Feb 23, 2026

Codecov Report

❌ Patch coverage is 84.21053% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.21%. Comparing base (e9118cf) to head (2448a8c).

Files with missing lines Patch % Lines
flow/record/base.py 85.71% 2 Missing ⚠️
flow/record/selector.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #216      +/-   ##
==========================================
+ Coverage   84.18%   84.21%   +0.03%     
==========================================
  Files          35       35              
  Lines        3736     3737       +1     
==========================================
+ Hits         3145     3147       +2     
+ Misses        591      590       -1     
Flag Coverage Δ
unittests 84.21% <84.21%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Grouped records fail for SQLite adapter

1 participant