Allow spaces in -F/--fields and -X/--exclude values#213
Allow spaces in -F/--fields and -X/--exclude values#213
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
==========================================
+ Coverage 84.18% 84.20% +0.02%
==========================================
Files 35 35
Lines 3736 3741 +5
==========================================
+ Hits 3145 3150 +5
Misses 591 591
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR addresses issue #212 by making rdump accept comma-separated --fields/-F and --exclude/-X values that include surrounding whitespace, so users can write lists like "foo, bar" without breaking field selection.
Changes:
- Strip whitespace around individual field names parsed from
--fieldsand--excludeinrdump. - Add a regression test ensuring spaced field lists work for both inclusion and exclusion.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
flow/record/tools/rdump.py |
Strips whitespace when parsing --fields / --exclude into lists used for record rewriting. |
tests/tools/test_rdump.py |
Adds a test case validating spaced field lists for --fields and --exclude. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
fixes #212