Skip to content

fix: make hasReturningUrl public for form submission pages #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ephraimduncan merged 2 commits into from
Jan 26, 2026
Merged

fix: make hasReturningUrl public for form submission pages #119

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
41abbe6
fix: make hasReturningUrl public for form submission pages
ephraimduncan Jan 26, 2026
2d387c7
refactor: rename hasReturningUrl to getReturnUrl
ephraimduncan Jan 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion apps/web/src/app/s/[formId]/page.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ export default async function FormCompletedPage({
params: Promise<{ formId: string }>;
}) {
const { formId } = await params;
const form = await api.form.hasReturningUrl({ formId });
const form = await api.form.getReturnUrl({ formId });

if (!form) {
return (
Expand Down
15 changes: 7 additions & 8 deletions packages/api/routers/form.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -212,15 +212,14 @@ export const formRouter = createTRPCRouter({
}),
),

hasReturningUrl: protectedProcedure
.input(
z.object({
formId: z.string(),
}),
)
getReturnUrl: publicProcedure
.input(z.object({ formId: z.string() }))
.query(async ({ ctx, input }) => {
const form = await assertFormOwnership(ctx, input.formId);
return { returnUrl: form.returnUrl };
const form = await ctx.db.query.forms.findFirst({
where: (table) => eq(table.id, input.formId),
columns: { returnUrl: true },
});
return { returnUrl: form?.returnUrl ?? null };
}),

formSubmissions: protectedProcedure
Expand Down
Loading