fix: make hasReturningUrl public for form submission pages #119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Form completion pages (/s/[formId]) need to check if a returnUrl exists, but were using protectedProcedure which caused sporadic UNAUTHORIZED errors for anonymous form submitters.
- "has" prefix implies boolean but returns actual URL value - Aligns with codebase convention for data fetching procedures
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
hasReturningUrlfromprotectedProceduretopublicProcedure/s/[formId]) were causing sporadic UNAUTHORIZED errors for anonymous form submittersreturnUrlis not sensitive data and formId is already exposed in the URLTest plan
bun run build)/s/[any-form-id]no longer returns 500