fix: update release workflow and formula for new bundle structure#197
Merged
forketyfork merged 2 commits intomainfrom Feb 4, 2026
Merged
fix: update release workflow and formula for new bundle structure#197forketyfork merged 2 commits intomainfrom
forketyfork merged 2 commits intomainfrom
Conversation
The bundle script now uses `architect` directly as the main executable instead of a shell wrapper calling `architect.bin`. Update: - release.yaml: reference `architect` and sign app bundle with entitlements - architect.rb: copy binary directly, add NS*UsageDescription keys to Info.plist
There was a problem hiding this comment.
Pull request overview
Fixes the release workflow to align with the new bundle structure introduced in PR #196, where architect is now the direct executable instead of a shell wrapper calling architect.bin.
Changes:
- Updated code signing references from
architect.bintoarchitect - Added entitlements and app bundle signing for proper macOS notarization
- Simplified Homebrew formula to copy binary directly without shell wrapper
- Added privacy permission keys to Info.plist
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
.github/workflows/release.yaml |
Updated signing process to reference architect instead of architect.bin and added entitlements flags |
Formula/architect.rb |
Replaced shell wrapper script with direct binary copy and added NS*UsageDescription keys for privacy permissions |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Replace cp + chmod with install, which handles permissions automatically.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the release workflow failure caused by the bundle structure change in PR #196. The bundle script now uses
architectdirectly as the main executable instead of a shell wrapper callingarchitect.bin.Changes
.github/workflows/release.yaml:architect.binreferences toarchitect--entitlementsflag when signing the binary.appbundle (required for notarization)Formula/architect.rb:architectinstead of using a shell wrapperTest plan