fix: remove double-free bugs in openUrl #194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue: A reviewer identified that the openUrl function contained double-free bugs where manual cleanup was performed before returning an error, but the registered errdefer statements would also execute on error return. Solution: Remove manual cleanup calls (destroy and deinit) in catch blocks since returning an error already triggers the errdefer cleanup handlers. The errdefer mechanism exists precisely for this purpose - to ensure cleanup happens exactly once when returning an error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes double-free bugs in
openUrlidentified by a reviewer on PR #191.Problem
The
openUrlfunction had two double-free bugs:dupefailed, manualdestroy(ctx)was called before returning the error, but theerrdeferon line 34 would also trigger on error returnThread.spawnfailed,ctx.deinit()freed both url and ctx, then returning an error triggered botherrdeferstatementsSolution
Remove the manual cleanup calls in catch blocks. The
errdefermechanism exists precisely for this purpose — to ensure cleanup happens exactly once when returning an error. Leterrdeferdo its job.Test plan
zig buildpasseszig build testpasses