Add custom delimiter option#3
Open
kamikazechaser wants to merge 3 commits intoforfuturellc:masterfrom
Open
Conversation
Users can now choose "sane" delimiter options such as: "~", "+", "/", "#", among others. Sticking with old ES5 syntax for forming strings. Regex limits delimiters to certain sane delimiter values i.e. https://en.wikipedia.org/wiki/Delimiter-separated_values Defaults to "-"
+ Example fixed & updated
Member
Author
|
MFW i didn't see PR #2. FFS. |
Member
Author
|
I guess the string padding at at the ends of the delimiter should be removed. i.e so the ids become Though it should default to |
- Update regex to allow for white space at the ends between delimiters for more flexibility - Update example
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Users can now choose "sane" delimiter options such as:
"~", "+", "/", "#", among others.Sticking with old ES5 syntax for forming strings.
Regex limits delimiters to certain sane delimiter values i.e. https://en.wikipedia.org/wiki/Delimiter-separated_values
Defaults to
"-"I think project is kinda old but we can add a tiny feature to it, probably not very useful though.