Support loading from non-os.File readers and add tests for loading meshes#29
Open
jordan-bonecutter wants to merge 3 commits intofogleman:masterfrom
Open
Support loading from non-os.File readers and add tests for loading meshes#29jordan-bonecutter wants to merge 3 commits intofogleman:masterfrom
jordan-bonecutter wants to merge 3 commits intofogleman:masterfrom
Conversation
Author
|
Hey @fogleman, I'm sure you're busy and maybe don't have time to look at MRs on this repo but I hope you may find this one useful, I did a few things:
Thanks for an awesome repo, it's very useful! |
436bf5c to
e552f3e
Compare
e552f3e to
b4c189c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It would be nice to be able to load an obj file from an
io.ReadCloserfor scenarios when you don't have an OS file and don't want to write one to disk just to load it.