Allow preserving existing values during DBAL upsert #2130
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stloyd
commented
Jan 6, 2026
Comment on lines
-27
to
-36
| if (count($columns) === 1) { | ||
| $column = $columns[0]; | ||
|
|
||
| return \sprintf( | ||
| 'DELETE FROM %s WHERE %s IN (%s)', | ||
| $table->name(), | ||
| $this->platform->quoteIdentifier($column), | ||
| $bulkData->toSqlPlaceholders() | ||
| ); | ||
| } |
Member
Author
There was a problem hiding this comment.
Query is the same in all dialects and always uses WHERE + IN(), the only difference is count() + extract instead of using array_map, which in fact covers the same cases.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2130 +/- ##
==========================================
+ Coverage 82.87% 83.12% +0.24%
==========================================
Files 1178 1178
Lines 41731 41733 +2
==========================================
+ Hits 34586 34690 +104
+ Misses 7145 7043 -102
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves: #2128
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security