Open
Conversation
This was
linked to
issues
Feb 19, 2025
Contributor
|
can you merge our master back into your branch? |
Author
|
Hey @bovine, thanks for reviewing! I just merged your master branch. |
Contributor
|
nice, the CI are all green now |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
This should fix these issues:
The main problem was that for some reason a pointer to the curl multi handle (CURLM*) was used instead of a curlMultiObjData pointer.
The latter has the multi handle and a linked list to all the child handles as members. Trying to add an easy handle to that linked list crashed if just a simple multi handle pointer is used.
I tried to keep the fixes small so they can be reviewed easier. It's similar to parts of #19 which I discovered after fixing these bugs myself :)
It can be tested easily as things like single.tcl from tests/multi are working now. I used Ubuntu 24.04 with their default libcurl3t64-gnutls package.
Cheers,
Stephan