Fixes #794 in the PhotoSwipe Framework #795
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: PhotoSwipe 4.X.X, currently 4.1.3, is no longer being maintained. To upgrade to 5.X.X, the plugin requires a complete refactoring. https://github.com/dimsemenov/PhotoSwipe/releases?page=2 Changes: - Passive support detection (features.passive). - framework.bind(...) extended with optional listener options argument. - Scroll lock in modal mode (HTML/BODY overflow:hidden, with scrollbar compensation) to prevent background scrolling when wheel listeners are passive. - DesktopZoom: Wheel events are bound passively ({passive:true}) if modal mode + browser supports passive listeners. - In handleMouseWheel(), preventDefault() is only executed if the listener is not passive. - Minified JS removed because it contains obsolete code and is difficult to maintain.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #794
Note: PhotoSwipe 4.X.X, currently 4.1.3, is no longer being maintained. To upgrade to 5.X.X, the plugin requires a complete refactoring. https://github.com/dimsemenov/PhotoSwipe/releases?page=2
Changes:
framework.bind(...)extended with optional listener options argument.overflow:hidden, with scrollbar compensation) to prevent background scrolling when wheel listeners are passive.{passive:true}) if modal mode + browser supports passive listeners.handleMouseWheel(),preventDefault()is only executed if the listener is not passive.